bug#17877: 24.3.92; Errors from cua-rectangle-mark-mode

bug#17877: 24.3.92; Errors from cua-rectangle-mark-mode

[penthief]

Emacs can be put into a state where calling #'cua-rectangle-mark-mode 
results in an error.

1. Create file bug-cua-rectangle.el with the following contents:

(require 'cua-rect)

(defun bug-cua-rectangle ()
   (interactive)
   (cua-rectangle-mark-mode)
   (cua-toggle-rectangle-mark)
   (cua-rectangle-mark-mode))

2. Start Emacs:

$ emacs -Q -l ~/bug-cua-rectangle.el

3. Eval bug-cua-rectangle:

M-x bug-cua-rectange

The following is output in the *Messages* buffer:

cua--activate-rectangle: Wrong type argument: arrayp, nil

Emacs is now in a state where we cannot enable cua-rectangle-mark-mode, 
and repeatedly calling #'cua-rectangle-mark-mode results in the 
following messages:

cua--activate-rectangle: Wrong type argument: arrayp, nil
Cua-Rectangle-Mark mode disabled
cua--activate-rectangle: Wrong type argument: arrayp, nil
Cua-Rectangle-Mark mode disabled
cua--activate-rectangle: Wrong type argument: arrayp, nil

Regards,
Matt

In GNU Emacs 24.3.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
  of 2014-06-29 on zz
Windowing system distributor `The X.Org Foundation', version 
11.0.11501000
System Description:	Ubuntu 14.04 LTS

Configured using:
  `configure --with-dbus --with-libotf --with-m17n-flt'

Important settings:
   value of $LC_CTYPE: en_US.UTF-8
   value of $LANG: en_US.UTF-8
   value of $XMODIFIERS: @im=ibus
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   cua-rectangle-mark-mode: t
   tooltip-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t

Recent input:
M-x b u g - c <tab> <return> y M-x r e p <tab> - e
- b <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
This will modify the current buffer. Continue? (y or n) y
Mark set
C-?:help M-p:pad M-o:open M-c:close M-b:blank M-s:string M-f:fill 
M-i:incr M-n:seq
cua--activate-rectangle: Wrong type argument: arrayp, nil
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
help-fns mail-prsvr mail-utils help-mode easymenu cua-rect rect cua-base
time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode prog-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process gfilenotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty emacs)

Memory information:
((conses 16 75495 9749)
  (symbols 48 17796 0)
  (miscs 40 38 125)
  (strings 32 10140 4554)
  (string-bytes 1 277453)
  (vectors 16 10143)
  (vector-slots 8 391417 12091)
  (floats 8 67 247)
  (intervals 56 225 3)
  (buffers 960 12)
  (heap 1024 19106 803))

bug#17877: 24.3.92; Errors from cua-rectangle-mark-mode

[Glenn Morris]

penthief wrote:

> cua--activate-rectangle: Wrong type argument: arrayp, nil

With almost no testing, this seems to fix it:

*** lisp/emulation/cua-rect.el	2014-01-01 07:43:34 +0000
--- lisp/emulation/cua-rect.el	2014-06-29 23:36:26 +0000
***************
*** 726,735 ****
    ;; Set cua--rectangle to indicate we're marking a rectangle.
    ;; Be careful if we are already marking a rectangle.
    (setq cua--rectangle
!         (if (and cua--last-rectangle
                   (eq (car cua--last-rectangle) (current-buffer))
!                  (eq (car (cdr cua--last-rectangle)) (point)))
!             (cdr (cdr cua--last-rectangle))
            (cua--rectangle-get-corners))
          cua--status-string (if (cua--rectangle-virtual-edges) " [R]" "")
          cua--last-rectangle nil)
--- 726,735 ----
    ;; Set cua--rectangle to indicate we're marking a rectangle.
    ;; Be careful if we are already marking a rectangle.
    (setq cua--rectangle
!         (or (and cua--last-rectangle
                   (eq (car cua--last-rectangle) (current-buffer))
!                  (eq (car (cdr cua--last-rectangle)) (point))
!                  (cdr (cdr cua--last-rectangle)))
              (cua--rectangle-get-corners))
          cua--status-string (if (cua--rectangle-virtual-edges) " [R]" "")
          cua--last-rectangle nil)

bug#17877: 24.3.92; Errors from cua-rectangle-mark-mode

[Mat Smiglarski]

On 2014-06-30 00:38, Glenn Morris wrote:
> penthief wrote:
> 
>> cua--activate-rectangle: Wrong type argument: arrayp, nil
> 
> With almost no testing, this seems to fix it:

Yes, your patch seems to work perfectly.

> 
> *** lisp/emulation/cua-rect.el	2014-01-01 07:43:34 +0000
> --- lisp/emulation/cua-rect.el	2014-06-29 23:36:26 +0000
> ***************
> *** 726,735 ****
>     ;; Set cua--rectangle to indicate we're marking a rectangle.
>     ;; Be careful if we are already marking a rectangle.
>     (setq cua--rectangle
> !         (if (and cua--last-rectangle
>                    (eq (car cua--last-rectangle) (current-buffer))
> !                  (eq (car (cdr cua--last-rectangle)) (point)))
> !             (cdr (cdr cua--last-rectangle))
>             (cua--rectangle-get-corners))
>           cua--status-string (if (cua--rectangle-virtual-edges) " [R]" 
> "")
>           cua--last-rectangle nil)
> --- 726,735 ----
>     ;; Set cua--rectangle to indicate we're marking a rectangle.
>     ;; Be careful if we are already marking a rectangle.
>     (setq cua--rectangle
> !         (or (and cua--last-rectangle
>                    (eq (car cua--last-rectangle) (current-buffer))
> !                  (eq (car (cdr cua--last-rectangle)) (point))
> !                  (cdr (cdr cua--last-rectangle)))
>               (cua--rectangle-get-corners))
>           cua--status-string (if (cua--rectangle-virtual-edges) " [R]" 
> "")
>           cua--last-rectangle nil)

bug#17877: 24.3.92; Errors from cua-rectangle-mark-mode

[Glenn Morris]

Version: 24.3.93

Thanks; applied to emacs-24 branch.