From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#29842: 27.0; `dired-change-marks': args should not be optional Date: Sun, 24 Dec 2017 10:30:54 -0800 (PST) Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1514140220 3224 195.159.176.226 (24 Dec 2017 18:30:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 24 Dec 2017 18:30:20 +0000 (UTC) To: 29842@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 24 19:30:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTB2M-0000BT-5y for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Dec 2017 19:30:14 +0100 Original-Received: from localhost ([::1]:34297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTB4J-0002Lu-3l for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Dec 2017 13:32:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTB4A-0002LN-Qx for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2017 13:32:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eTB46-0004AU-UF for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2017 13:32:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42223) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eTB46-0004AK-Pc for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2017 13:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eTB46-0005Af-7V for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2017 13:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Dec 2017 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29842 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29842-submit@debbugs.gnu.org id=B29842.151414026419802 (code B ref 29842); Sun, 24 Dec 2017 18:32:02 +0000 Original-Received: (at 29842) by debbugs.gnu.org; 24 Dec 2017 18:31:04 +0000 Original-Received: from localhost ([127.0.0.1]:50904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTB3A-00059K-EP for submit@debbugs.gnu.org; Sun, 24 Dec 2017 13:31:04 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:39618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTB38-00058p-KT for 29842@debbugs.gnu.org; Sun, 24 Dec 2017 13:31:02 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBOIUZHl067648 for <29842@debbugs.gnu.org>; Sun, 24 Dec 2017 18:30:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=RNAG8FAC+T8dVjV8kE1f3ta4qKM3YLYXpixlmm7knxg=; b=swMJfby6raRQ9wqwqMI+McahgSBMEGnwzDdcuHteH0UxQpyHqsilmm6IcFwVF4uxJBQE Iua56hVIYzDeK7mTXiAGkU/LP1OGeeCDs3Hz7zg1m+1nWwjYeu7kBDSlv/uVuNOPR6B4 oourrh7v7L/r2M04xPQy9Dm54Qr6av2Yw8W+Qv+iEJmbvGDIS5i1t6jk9EEquOGdHPZf On3YEUqzf0w7coPDu4duVBcaCM1D8V2UtYbF7RrW7BDyibL3SZ35RoOT++SJHdKDkpJD sQO9ALwIDVKxwjmX6+7XZMdvwKFs81cVdgj30SI7KdjEk2vQl8aeoCZm3+25gRj1/lJE BQ== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2f2hju8019-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <29842@debbugs.gnu.org>; Sun, 24 Dec 2017 18:30:56 +0000 Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBOIUu9J026168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for <29842@debbugs.gnu.org>; Sun, 24 Dec 2017 18:30:56 GMT Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vBOIUtOn026303 for <29842@debbugs.gnu.org>; Sun, 24 Dec 2017 18:30:56 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4627.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8755 signatures=668650 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=13 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=853 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712240254 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141458 Archived-At: Furthermore, the code should perhaps not just call `ding' if you hit RET. Instead of this: (if (or (eq old ?\r) (eq new ?\r)) (ding) ...) it should perhaps do something like this: (unless (char-displayable-p old) (error "Not a displayable character: `%c'" old)) (unless (char-displayable-p new) (error "Not a displayable character: `%c'" new)) The current code predates the existence of `char-displayable-p'. (Yes, that's a different bug, but perhaps it can be taken care of in the context of this report. If not, don't worry about it.)