From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Date: Wed, 2 Nov 2022 12:57:57 -0700 Message-ID: References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10464"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58909@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 20:59:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqJtP-0002Tr-9m for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 20:59:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqJt9-0008VY-Sl; Wed, 02 Nov 2022 15:59:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqJt8-0008VR-Q6 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 15:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqJt8-0005i8-Is for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 15:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqJt8-0002AA-3x for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 15:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 19:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16674190848246 (code B ref 58909); Wed, 02 Nov 2022 19:59:02 +0000 Original-Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 19:58:04 +0000 Original-Received: from localhost ([127.0.0.1]:47228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqJsB-00028w-Vt for submit@debbugs.gnu.org; Wed, 02 Nov 2022 15:58:04 -0400 Original-Received: from mail-pf1-f178.google.com ([209.85.210.178]:42973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqJsA-00028S-H3 for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 15:58:02 -0400 Original-Received: by mail-pf1-f178.google.com with SMTP id b185so17361168pfb.9 for <58909@debbugs.gnu.org>; Wed, 02 Nov 2022 12:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=bovSnHUPXKeA/WxOtwZEBld7aRIBzYG8dPaGBgHP7Co=; b=LT5kHsHzSYSAvwxZPNARgO22rDcaATdza42Oc283ymhDfzMTGucCIiLUXMeAHG0nct Jjc/v0pBq0D3xVTUANIS38C3syTJj3RgzN4V4CNL1C3WNwY9BpVKbcIP8IuR91IKG5NA zuxh/L4PdgqGcjhA8NEX8d3KIdu555GA0SU9nSs/nNci9t584Q6Gfa62G8JvjETYFJja OYpBta3xFdCDju+uPYDuhoXMmA4WoxMVAs2iWseN5GKiFeHEVcXnA63mff7ZhyrqOtjV uxXXaz5wR8OHffTCLunsh6673P/sGGZAzR0TRW00HYSVOsqtq7VMpREgT7t3ipbLgS4B 1I2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bovSnHUPXKeA/WxOtwZEBld7aRIBzYG8dPaGBgHP7Co=; b=eEmfjjOx3cuZSKtNiTbgjiYbN3IH71hSXrU02+13TAU482xmlRMesuVlpubAEMTzFb NajuT4uh/raaB5moziXYzgYwrhv9tTQl9HQmPtoS7Xm+0gJyY6N1gttCxIsyqxH3tR6W u4ErpjdcqDf5jX91hsBs6cU+7JmTDwbgyBGyd7c2oYkjweq4DjG8k99rtdzQT333bsRh C/P2qErRQUq0gFU9NVpKL+hEDgdl6CAmlgNEQR3067f1/87SZjZtgxVpD3zCLlWkqAX+ FIMfQjraqq8uC0JSNpS/Uc8YhgG+TiUoT56u12FFKsVgYUDjX1iZqDMWoy1iB12Vqwzz 1nFg== X-Gm-Message-State: ACrzQf34ksAUYbxtrePS61MDAWt0EgKNF+PPo7+rnJpF9VZae2oejVPT AKdmZV9Hc0zawrEwg6cDung= X-Google-Smtp-Source: AMsMyM7baB9RtZ6wrA1/4f4e96cBdDRHiCkLbkOvZ/G5wuGt9igl1WbWGIHnC1es0jItCwgSDzCUpA== X-Received: by 2002:a63:66c3:0:b0:470:8fd:7bae with SMTP id a186-20020a6366c3000000b0047008fd7baemr4243183pgc.277.1667419076621; Wed, 02 Nov 2022 12:57:56 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id oj5-20020a17090b4d8500b001df264610c4sm3546042pjb.0.2022.11.02.12.57.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 12:57:55 -0700 (PDT) Content-Language: en-US In-Reply-To: <831qql9n4s.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246891 Archived-At: On 11/2/2022 12:23 PM, Eli Zaretskii wrote: > Isn't the last suggestion, of having an optional prompt in > server-delete-client, good enough? 'server-delete-client' is called in a bunch of spots, so at minimum, I'd want to be extra-careful that prompting doesn't break one of those cases. It would also be nice if I could fix the C-g issue, at least in my local configuration. Still, I'll take a look at doing this if you think it would be good to add to Emacs. (If you think it's not needed, I really don't mind leaving the code as-is.) >>> Why is it important to have the mode turned on? What can a mode do >>> that we cannot do without a mode? >> >> If starting the server activates a minor mode, then Emacs can use a >> minor-mode keymap for server-mode. [snip] > > I'm fine with doing that, but we must also make sure this mode is > turned on when users invoke server-start interactively. I think that makes sense, and it should be fairly straightforward. I'll work on a patch for this. Thanks again for the extensive feedback.