From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files Date: Fri, 3 Jan 2020 03:52:27 +0300 Message-ID: References: <9d65284f-7a64-5e9c-ab02-fbbd1be41689@yandex.ru> <87r2bt1tio.fsf@gmx.de> <2cfd53b2-8202-a321-a853-da0c949b0f15@yandex.ru> <6cf8bfa8-3873-d3db-9139-854359027e8a@yandex.ru> <87h81mqiq5.fsf@gmx.de> <0ff03b20-20d8-b6c0-c876-3fd525586180@yandex.ru> <87mubdps6s.fsf@gmx.de> <87blrsz3tf.fsf@gmx.de> <87blrrmht9.fsf@gmx.de> <87tv5fs6kf.fsf@gmx.de> <7a1e2e22-89d4-b8b9-6cd4-e6947436138c@yandex.ru> <87mub6uoa6.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="8073"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: =?UTF-8?Q?Felici=C3=A1n_?= =?UTF-8?Q?N=C3=A9meth?= , 34343@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 03 01:53:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1inBDD-0001xd-4N for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2020 01:53:11 +0100 Original-Received: from localhost ([::1]:47420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inBDB-0000hk-IS for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Jan 2020 19:53:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32958) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inBD5-0000he-Hr for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 19:53:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inBD4-0003oW-H9 for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 19:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34259) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inBD4-0003oA-B5 for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 19:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inBD4-0007BX-7U for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 19:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2020 00:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34343-submit@debbugs.gnu.org id=B34343.157801275927587 (code B ref 34343); Fri, 03 Jan 2020 00:53:02 +0000 Original-Received: (at 34343) by debbugs.gnu.org; 3 Jan 2020 00:52:39 +0000 Original-Received: from localhost ([127.0.0.1]:40232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inBCh-0007As-Jv for submit@debbugs.gnu.org; Thu, 02 Jan 2020 19:52:39 -0500 Original-Received: from mail-lj1-f176.google.com ([209.85.208.176]:42960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inBCf-0007Ag-Tf for 34343@debbugs.gnu.org; Thu, 02 Jan 2020 19:52:38 -0500 Original-Received: by mail-lj1-f176.google.com with SMTP id y4so28045318ljj.9 for <34343@debbugs.gnu.org>; Thu, 02 Jan 2020 16:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=StqA4JokL1Z0PJKfNWU9VWQCKq2dGujfSYWeuucf/EY=; b=BKs/XVB3qeCoMQVRC6yZ73to7uP0a7YLVDuWsrIt0rXSNFwt0JtnWc0Mg7Phd1OQkj OY5SUuDE8n0nrCFxUud/983+m7ZWTpMLjaeJ9oHRUgmHJzK/jcn79bzHRqeXff3TW4fF ldgTbD5rH2nfzngznN3EUKspwNGcv3qs9tDX9fPoKurSWLHmlDhpEomIM24fx951Bx08 vvLjcORxzrkkHREZInp7jeXXe7e5sfLDCZBtpbPy9rIRsVRHZGs5J+xgdB7ZSg/1spwo mMKRQPz0x/Nlcd/lIWuy7PAKE7v3JQoIvJWMIC3m+CKoCQntZPn04Mq6GlEfONUl8PBJ fCbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=StqA4JokL1Z0PJKfNWU9VWQCKq2dGujfSYWeuucf/EY=; b=TRWmMHux/Lo7Ds+RKf44Nz7DgISGZS3vrA5vClz/VkPgBMv2Mw1Yp5h9gU+e/5EonC YtuTC7qWfUlGzZOmY6F7sE/SWg17/ff4s56lBkSgr2E5PzYqZZaCDJCmaEwWZ2ojTM0q 2UuX6CA2lY1TD6Wk23SIZPBtGSe6OG5Xm7iHzVjIzx4vhfaux9sqy6kBlSujsupHOxdV i4TkG1xsJVJ4K1BHqtk2jSOVBUahuy74S4muZlzqqmRL+zLt67h/kv9ItMXnddujBYEj 2K3TJyPMSeOJgICDavOFdp7ROU0B4ncolm99F/6T72cSYg8FNh7XqLrq8WXMtWYL/0qb sNjQ== X-Gm-Message-State: APjAAAWXaJEy6EIeZZcmasuP5BgPWbqY7VyfEiQ3nnm57e5O2Y0RwK5o 34rvmCLYSeVASgDPKgOkeraW8eLmi0U= X-Google-Smtp-Source: APXvYqzmv0DmQ+DCFSte6/kyZNmdKemuuoria3T+ar0RdU7g7+KqvMi2rto2ZFyiO1bx1lMemaFASA== X-Received: by 2002:a2e:b4f6:: with SMTP id s22mr51059614ljm.218.1578012751560; Thu, 02 Jan 2020 16:52:31 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id l12sm23547241lji.52.2020.01.02.16.52.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jan 2020 16:52:30 -0800 (PST) In-Reply-To: <87mub6uoa6.fsf@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174087 Archived-At: On 02.01.2020 12:48, Michael Albinus wrote: > Then I have removed everything from tramp-handle-file-remote-p which > isn't necessary for the 'localname case, and I came to > ... > I cannot confirm "twice as long". I've tried ... My file names are longer still. I can give a specific example later, if you like. > The difference is likely because tramp-file-name-regexp has been > applied to a longer string. > > If I simplify tramp-file-name-regexp, we get ... Both are fine avenues for exploration, I think. But most importantly for now: tramp-handle-file-remote-p does not take up the majority of time spent in file-remote-p. tramp-file-name-handler does: ELISP> (benchmark 10000 '(file-remote-p "/ssh:abc@def.com:/%d" nil t)) "Elapsed time: 3.535115s (2.112970s in 27 GCs)" ELISP> (benchmark 10000 '(tramp-handle-file-remote-p "/ssh:abc@def.com:/%d" nil t)) "Elapsed time: 0.780867s (0.645621s in 8 GCs)" ELISP> (benchmark 10000 '(find-file-name-handler "/ssh:abc@def.com:/" 'file-remote-p)) "Elapsed time: 0.070135s" ELISP> (benchmark 10000 '(tramp-file-name-handler 'file-remote-p "/ssh:abc@def.com:/%d" nil t)) "Elapsed time: 3.409674s (2.070461s in 27 GCs)" And that function does a lot of things that I'm not sure we need to just get the remote id.