unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
	Tom Willemse <tom@ryuslash.org>
Cc: 14941-done@debbugs.gnu.org
Subject: bug#14941: [Patch] Lighten up wrt version specification
Date: Thu, 13 Mar 2014 08:42:00 -0700 (PDT)	[thread overview]
Message-ID: <ba1e930a-28c2-454b-8bc2-0b2d7ab8d012@default> (raw)
In-Reply-To: <jwveh26z0hl.fsf-monnier+bug#14941@gnu.org>

> I installed this hunk, but not the other.

IOW, you did not fix bug #14941.  Neither the "this hunk" nor "the
other" you refer to are part of the bug 14941 thread; they are part of
#15108.  Please change bug #14941 to "wont-fix", which correctly reflects
its new status.

> If a "Version:" header is missing, it should stay as an error, because
> package.el relies heavily on version numbers.

There is no such "because" - illogical.  That package.el relies heavily
on version numbers is irrelevant.  It need not rely on the presence of
a `Version:' specification to nevertheless rely on a version number.

It need simply consider lack of an explicit `Version:' spec as
specifying version 0.  It is reasonable to have a default behavior,
and that is the right default value.

As for `Version: ' vs `Version: 0': As the bug #14941 report says, an
empty version field can indicate - to human readers - that the file is
not versioned.  For package.el it means only that any version will do
when the file is required.  But to humans it can indicate more: that the
file is not versioned.  This is a minor point, but there is no reason
for package.el to require the explicit "0".

It's a program.  It can assume "0" for an empty field here, just as it
can assume `Version: 0' for no version spec.





  reply	other threads:[~2014-03-13 15:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 17:32 bug#14941: 24.3.50; package.el should lighten up wrt version specification Drew Adams
2014-02-20 23:19 ` bug#14941: [Patch] Lighten " Tom Willemse
2014-03-13 13:35   ` Stefan Monnier
2014-03-13 15:42     ` Drew Adams [this message]
2014-03-13 22:12       ` Stefan Monnier
2014-03-13 23:57         ` Drew Adams
2014-03-14 13:18           ` Stefan Monnier
2014-03-16 22:15             ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba1e930a-28c2-454b-8bc2-0b2d7ab8d012@default \
    --to=drew.adams@oracle.com \
    --cc=14941-done@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=tom@ryuslash.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).