bug#60050: 29.0.60;

bug#60050: 29.0.60;

[Konstantin]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hello,

Right now there are few minor mistakes in the building script for
tree-sitter modules.
/admin/notes/tree-sitter/build-module/batch.sh

It builds some modules which are not supported by emacs yet. For example
html, rust, go. It does not build the "bash" module, which is
supported by emacs.




[-- Attachment #2: build_modules.path --]
[-- Type: application/octet-stream, Size: 437 bytes --]

diff --git a/admin/notes/tree-sitter/build-module/batch.sh b/admin/notes/tree-sitter/build-module/batch.sh
index c395449..89abb2b 100755
--- a/admin/notes/tree-sitter/build-module/batch.sh
+++ b/admin/notes/tree-sitter/build-module/batch.sh
@@ -7,12 +7,10 @@ languages=(
     'css'
     'c-sharp'
     'dockerfile'
-    'go'
-    'html'
     'javascript'
     'json'
     'python'
-    'rust'
+    'bash'
     'typescript'
     'tsx'
 )

bug#60050: 29.0.60;

[Randy Taylor]

On Tuesday, December 13th, 2022 at 16:44, Konstantin <reich-cv@yandex.ru> wrote:
> 
> Hello,
> 
> Right now there are few minor mistakes in the building script for
> tree-sitter modules.
> /admin/notes/tree-sitter/build-module/batch.sh
> 
> It builds some modules which are not supported by emacs yet. For example
> html, rust, go. It does not build the "bash" module, which is
> supported by emacs.
> 

I have a patch being reviewed for go support, and I'm working on rust support now.

Jostein already posted a patch adding bash (as part of toml support).

I'm not sure there's any harm in keeping html around, but we'll see what Yuan thinks.

bug#60050: 29.0.60;

[Stefan Kangas]

Randy Taylor <dev@rjt.dev> writes:

> I'm not sure there's any harm in keeping html around, but we'll see
> what Yuan thinks.

I think having more modes than are needed is fine, as this script is
supposed to only be a help during development.  If someone starts
working on an HTML treesitter mode, they will be happy to find that it's
already there.

bug#60050: 29.0.60;

[Randy Taylor]

On Tuesday, December 13th, 2022 at 18:02, Stefan Kangas <stefankangas@gmail.com> wrote:
> 
> Randy Taylor dev@rjt.dev writes:
> 
> > I'm not sure there's any harm in keeping html around, but we'll see
> > what Yuan thinks.
> 
> 
> I think having more modes than are needed is fine, as this script is
> supposed to only be a help during development. If someone starts
> working on an HTML treesitter mode, they will be happy to find that it's
> already there.

Closing this since the script now supports all those languages and there are modes for each one of them. And we have the new `treesit-install-langauge-grammar` command which seems to be the preferred way to install the grammars now.