From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Seppo Ronkainen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63283: Emacs crash within fontset Date: Mon, 08 May 2023 21:22:21 +0000 Message-ID: References: <83wn1njswh.fsf@gnu.org> <835y95hicm.fsf@gnu.org> <7viubPQBitOqW2lvRK1P_aP6NjiS05pc86HGIH8yUyCZGabZgL5Hb3YAdm9efSCsxPb7yxW55zGhfZfE2PUjkZesUSharobfMDC3-JTEL1E=@protonmail.com> <835y95fe64.fsf@gnu.org> <83ttwoeiwf.fsf@gnu.org> Reply-To: Seppo Ronkainen Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36628"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63283@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 09 02:00:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwAmL-0009Eu-HE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 May 2023 02:00:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwAm1-0000qR-VW; Mon, 08 May 2023 20:00:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwAlw-0000pI-OW for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 20:00:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwAlw-0007vI-GC for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 20:00:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwAlw-0004HZ-C5 for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 20:00:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Seppo Ronkainen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 May 2023 00:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63283 X-GNU-PR-Package: emacs Original-Received: via spool by 63283-submit@debbugs.gnu.org id=B63283.168359036116333 (code B ref 63283); Tue, 09 May 2023 00:00:04 +0000 Original-Received: (at 63283) by debbugs.gnu.org; 8 May 2023 23:59:21 +0000 Original-Received: from localhost ([127.0.0.1]:41888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwAlF-0004FL-3Y for submit@debbugs.gnu.org; Mon, 08 May 2023 19:59:21 -0400 Original-Received: from mail-40134.protonmail.ch ([185.70.40.134]:56255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw8JS-00081K-IK for 63283@debbugs.gnu.org; Mon, 08 May 2023 17:22:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1683580944; x=1683840144; bh=KOlpSgWb8jFvTMRKlPLH9CCtGjhVXMMBT5LMr85mAwI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=nNWnEvpHyg3e9DdgdjVWj575rMceUK1nBYNSeH5NPXJgTmZN4su/VaKbgDuQ6YXL4 jg8nHCXJtqiMNaKadUfeYSuiU9Uqq9K/lfHAbRx6Yc6I3MunMqy4cL1zWgMXbiZ4bl KZHerEo85w6601482oRI0cwYE7i4jWxqDhUIWyRsCt875Rz1kOZEDofxxabxwUlrN9 5QtdlmB8OEg16ULOhlmS4qgR0Il7O4AfKiW5TqtAEgrF8F/0e/c0QQf5U/8Vftpco6 +a63/SMjr2ko6SOZlvY7NCwTXvRyp4wNY4UpbaSQsOuKaDjgiYKNQ2uez0GW7C/MbM NZTalWNRnWpGQ== In-Reply-To: <83ttwoeiwf.fsf@gnu.org> Feedback-ID: 7916417:user:proton X-Mailman-Approved-At: Mon, 08 May 2023 19:59:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261369 Archived-At: Your suggested patch successfully avoided the abort, great ! Where the abort would previously occur now instead the buffer renders all c= haracters with four digit code point rectangular representations which I wo= uld consider preferable to an abort the entire emacs server session with th= irty or so windows. Tested with visiting a large file emacs/src/xdisp.c and= Emacs swapps back to render regular characters when text is scaled back. I= would vote for your suggested fix, well done thank you ! Live long and prosper Sent with Proton Mail secure email. ------- Original Message ------- On Sunday, May 7th, 2023 at 6:48 AM, Eli Zaretskii wrote: > > Date: Sat, 06 May 2023 22:36:35 +0000 > > From: Seppo Ronkainen sodr80@protonmail.com > > Cc: 63283@debbugs.gnu.org > >=20 > > (gdb) frame 2 > > #2 0x00000055559233c4 in face_for_char (f=3D0x55564c8470, face=3D0x5556= 292b90, c=3D12302, pos=3D1, object=3DXIL(0)) at fontset.c:970 > > 970 eassert (fontset_id_valid_p (face->fontset)); > > (gdb) info locals > > fontset =3D XIL(0) > > rfont_def =3D XIL(0x555605b2b8) > > charset =3D XIL(0x300effff7380) > > face_id =3D 85 > > id =3D 1432078920 > > (gdb) print font_driver_list > > $1 =3D (struct font_driver_list *) 0x55560d77e0 > > (gdb) print f->font_driver_list > > $2 =3D (struct font_driver_list *) 0x5556274ae0 > > (gdb) frame 3 > > #3 0x00000055555bd308 in FACE_FOR_CHAR (f=3D0x55564c8470, face=3D0x5556= 292b90, character=3D12302, pos=3D1, object=3DXIL(0)) at dispextern.h:1911 > > (gdb) p face->font > > $5 =3D (struct font *) 0x0 > > (gdb) p face->fontset > > $6 =3D -1 > > (gdb) q >=20 >=20 > Thanks. If you apply the patch below, does it avoid the abort? >=20 > > relevant commit ? > > 3c0dda2663e38635163f0fd6c19748c6eba1c3c8 > > Avoid asserting for fontset validity before it is used >=20 >=20 > No, I don't think so. We'd just abort earlier in that function. >=20 > diff --git a/src/fontset.c b/src/fontset.c > index f196dee..e004cd9 100644 > --- a/src/fontset.c > +++ b/src/fontset.c > @@ -967,6 +967,9 @@ face_for_char (struct frame *f, struct face *face, in= t c, > #endif > } >=20 > + if (face->fontset < 0 && !face->font) >=20 > + return face->id; >=20 > + > eassert (fontset_id_valid_p (face->fontset)); >=20 > fontset =3D FONTSET_FROM_ID (face->fontset); >=20 > eassert (!BASE_FONTSET_P (fontset));