From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#65380: [PATCH] Add command to copy contents in a diff-mode buffer Date: Sun, 20 Aug 2023 15:21:30 -0700 Message-ID: References: <87wmxrwe6h.fsf@posteo.net> <83o7j3z4wm.fsf@gnu.org> <87pm3jwboc.fsf@posteo.net> <83lee7z3xs.fsf@gnu.org> <87jztrvxx2.fsf@posteo.net> <83r0nyyhlz.fsf@gnu.org> <3bee8689-f8b7-117e-0165-34df01366901@gmail.com> <22de08b62b5abe7309b8@heytings.org> <7896ab38-c938-2f08-806b-3543e8b64173@gmail.com> <22de08b62b886f50c32f@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28306"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65380@debbugs.gnu.org, Eli Zaretskii , Philip Kaludercic To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 21 00:22:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXqoT-0007CL-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Aug 2023 00:22:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXqo5-0004jC-7B; Sun, 20 Aug 2023 18:22:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXqo4-0004j4-1U for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 18:22:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXqo3-0002Hx-PR for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 18:21:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXqo5-0003et-Im for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 18:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 22:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65380-submit@debbugs.gnu.org id=B65380.169257010214029 (code B ref 65380); Sun, 20 Aug 2023 22:22:01 +0000 Original-Received: (at 65380) by debbugs.gnu.org; 20 Aug 2023 22:21:42 +0000 Original-Received: from localhost ([127.0.0.1]:55040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXqnm-0003eD-Bl for submit@debbugs.gnu.org; Sun, 20 Aug 2023 18:21:42 -0400 Original-Received: from mail-oa1-x33.google.com ([2001:4860:4864:20::33]:46439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXqnj-0003dw-Pm for 65380@debbugs.gnu.org; Sun, 20 Aug 2023 18:21:40 -0400 Original-Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-1c504386370so1767564fac.1 for <65380@debbugs.gnu.org>; Sun, 20 Aug 2023 15:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692570092; x=1693174892; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=A05ir9D29KDc1JwQtumNt7kahYkPGXwsPjcWqyUNC4g=; b=dk7Mn0225BuBBB99jRtmhVuOJt8sBvmHqoLp0iAtmlI3a3shycjjV9s96lJz4juSO0 QApmVZ/0N/8fyujIGVMuk/1pr4w7RhQBWAZWEMAevEm+4xhogxh7gDKXeVQlfYqWmVaj Y8qppcRNXroAJ6k9wbsuOGV1VVL+ElRz8KwGjp+t98xTVAnia5tTtVXKS3tzal0RIPEs TYfqpQYiPNkEaR4QtPcFG6GBYvy+/Fbcl90bc0n2Xgm7zbQ9sjpV7eCg9FccwJoWTTxY KdcXsTxhu+t9qltwKJ3XPomtL7yvVOk0ahsy0ea94u3MM7Hu5Canv2iy0KwFvyUm58Tl uywQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692570092; x=1693174892; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A05ir9D29KDc1JwQtumNt7kahYkPGXwsPjcWqyUNC4g=; b=Ejyp/wFpmmSAIy940bTcPFzwKp7l83ODjRz7YPEDBaDwVtjjwXhMTCBGoDFi9kdpma XloZQd3yxbKMeD+Fydd+P1ZxLlOoW8iuIz01soIjDtmNOX3TqLbzLf56uhRxgsTP6APL XTBV6cqQmIOJ+v4G3WffnZC4zHESlRjWv1HYS2P8o4dkEXI2zzBhVmsGPVnfhydWpuNL mmTwyTOLm1/XliuhTFhJr1ovTrD4QB80cJ/KwKZru8vUHfDiHC4JEi4rFOXZOVzUPuOl un2Qs9zj9EdyR2DdKYpHWJMW+tcoO8UY7kfOTTSu3bkUZw7wCmii8NHouPOeX230gfNZ 9ZfA== X-Gm-Message-State: AOJu0YwAre7LzRbYnLbWCPejcWSBHftPTQDPskrT484tmkvhjTySXymi ///fjMDAC1rwBpEge7wUr7o= X-Google-Smtp-Source: AGHT+IHLEIG3V5RkuM5DEOmNxPThzfbDM1mB2kgiTtaj2LUAUoEQj/2D/fqSr8seyZL5NoTKtJ2/ug== X-Received: by 2002:a05:6870:d149:b0:1c0:1424:5e79 with SMTP id f9-20020a056870d14900b001c014245e79mr7506782oac.42.1692570092103; Sun, 20 Aug 2023 15:21:32 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x52-20020a056a000bf400b006870ff20254sm4820904pfu.125.2023.08.20.15.21.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Aug 2023 15:21:31 -0700 (PDT) Content-Language: en-US In-Reply-To: <22de08b62b886f50c32f@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268040 Archived-At: On 8/20/2023 2:29 PM, Gregory Heytings wrote: > >> That's not quite what I mean. "C-x r y" ('yank-rectangle') yanks the >> rectangle *as a rectangle*. That is, if I just copied a rectangle with >> 5 lines, and yank it with 'yank-rectangle', it will add it to the next >> 5 existing lines. Instead, what I want is to insert 5 new lines. >> > > Indeed, I see what you mean.  Perhaps a new C-x r command that would do > that could be added to Emacs? Yeah, the question then is: should it be new kill/copy commands or a new yank command? The former would mean you could use all the existing yank functions to paste the text in, but the latter means you can defer your decision about how to yank the text (as a regular region or as a rectangle) until you're ready to actually yank. I'd lean a bit towards the former, but that does mean (potentially) two new key bindings. ... hmm, or maybe you could make the existing rectangle kill/copy commands also add to the "regular" kill ring automatically? But then that might cause issues with 'rectangle-mark-mode', where 'C-y' performs 'yank-rectangle'[1]: how would I use 'rectangle-mark-mode' to copy a rect and then paste it as a regular region? [1] Well, technically 'rectangle--insert-for-yank', but they both call 'insert-rectangle' in the end.