unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@linkov.net>
Cc: 49247@debbugs.gnu.org, s930054123yaoyao@gmail.com
Subject: bug#49247: 28.0.50; [Feature Request] Make tab-bar-lines dragable
Date: Wed, 7 Jul 2021 09:31:16 +0200	[thread overview]
Message-ID: <b913ea4a-cdc6-a07f-dd24-078af5b2bc43@gmx.at> (raw)
In-Reply-To: <87eecbcs47.fsf@mail.linkov.net>

 > The problem also can be fixed by removing this line from info.el
 > from Info-mode-map:
 >
 >    (define-key map [follow-link] 'mouse-face)

The same would have to be done at least for *Backtrace* where I've seen
the same problem.  And there are lots of other modes that use the above
idiom, I haven't looked into them.

 > Why buffer's mode keymap affects the behavior of clicking
 > on the tab-line?
[...]
 > The difference is that in the broken case it says:
 >
 >    "Those are influenced by `mouse-1-click-follows-link'"
 >
 > and translates <mouse-1> to <mouse-2>, where <mouse-2> is a valid
 > binding that closes the tab.  But translating <mouse-1> to <mouse-2>
 > is a bug, I don't know how to fix it.

It might happen in `mouse--click-1-maybe-follows-link' but that is
written in terms of `pcase' which I cannot read fluently.  Honestly,
key translations are a mystery to me.

I see two possibilities to fix this without further hassle.  Either I
revert my changes or you give up on binding mouse-1 and mouse-2 to
different actions.  I think that the mouse-2 binding at hand is not
useful because not all people can use it reliably (for example here the
scroll wheel may always slip slightly before pressing it) and all your
remaining keymaps bind mouse-1 and mouse-2 to the same action.  BTW, I
think that the mouse wheel should scroll the tab-line, if applicable.

martin





  reply	other threads:[~2021-07-07  7:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28  3:57 bug#49247: 28.0.50; [Feature Request] Make tab-bar-lines dragable Liang-Jie Lee
2021-06-28 19:46 ` Juri Linkov
     [not found]   ` <CAB+tG3vqkAC+TDtoTDP=REnG+ODVky35UCaQVTfbiN5m34xL5w@mail.gmail.com>
2021-06-29  8:30     ` Juri Linkov
2021-06-29 11:53       ` Eli Zaretskii
2021-06-29 13:16         ` martin rudalics
2021-06-30 11:54           ` Eli Zaretskii
2021-07-01  7:53             ` martin rudalics
2021-07-01  9:03               ` Eli Zaretskii
2021-07-02  9:03                 ` martin rudalics
2021-07-04 20:32                   ` Juri Linkov
2021-06-30 19:37           ` Juri Linkov
2021-07-01  7:54             ` martin rudalics
2021-07-01  9:05               ` Eli Zaretskii
2021-07-04 20:37                 ` Juri Linkov
2021-07-04 21:09                   ` bug#49247: [External] : " Drew Adams
2021-07-05  2:26                   ` Eli Zaretskii
2021-07-05  9:06                   ` martin rudalics
2021-07-05 20:54                     ` Juri Linkov
2021-07-06 16:29                       ` martin rudalics
2021-07-06 16:41                         ` Juri Linkov
2021-07-07  7:31                           ` martin rudalics [this message]
2021-07-07 14:02                             ` bug#49247: [External] : " Drew Adams
2021-07-07 22:54                             ` Juri Linkov
2021-07-08  1:32                               ` bug#49247: [External] : " Drew Adams
2021-07-08 17:51                         ` Juri Linkov
2021-06-29 20:41         ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b913ea4a-cdc6-a07f-dd24-078af5b2bc43@gmx.at \
    --to=rudalics@gmx.at \
    --cc=49247@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=s930054123yaoyao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).