From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ludovic Brenta Newsgroups: gmane.emacs.bugs Subject: bug#32510: xref-find-definitions should return file names, too Date: Thu, 18 Jul 2019 16:53:42 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="243708"; mail-complaints-to="usenet@blaine.gmane.org" To: 32510@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 18 16:54:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ho7nL-0011D4-Fu for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 16:54:07 +0200 Original-Received: from localhost ([::1]:38800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho7nK-0000gt-7t for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 10:54:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36942) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho7nH-0000gh-7F for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 10:54:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho7nG-0003ip-9d for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 10:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ho7nG-0003ie-57 for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 10:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ho7nG-0002pP-2c for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 10:54:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch wontfix Original-Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156346162710837 (code B ref 32510); Thu, 18 Jul 2019 14:54:02 +0000 Original-Received: (at 32510) by debbugs.gnu.org; 18 Jul 2019 14:53:47 +0000 Original-Received: from localhost ([127.0.0.1]:54479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho7n1-0002oh-4A for submit@debbugs.gnu.org; Thu, 18 Jul 2019 10:53:47 -0400 Original-Received: from webmail.bookmyname.com ([88.191.249.153]:15076 helo=webmail.free.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho7my-0002oO-RE; Thu, 18 Jul 2019 10:53:45 -0400 Original-Received: from 153.98.68.208 (unknown [127.0.1.3]) by webmail.free.org (Postfix) with ESMTP id C7474380B2; Thu, 18 Jul 2019 16:53:42 +0200 (CEST) Original-Received: from [153.98.68.208] by webmail.ludovic-brenta.org with HTTP (HTTP/1.1 POST); Thu, 18 Jul 2019 16:53:42 +0200 X-Sender: ludovic@ludovic-brenta.org Original-X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.ludovic-brenta.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163305 Archived-At: tags 32510 - wontfix thanks I can confirm that the patch by Eli Zaretskii works, with a difference compared to find-tag: find-tag opens the first file whose name matches the searched string whereas xref-find-definitions opens a new buffer with all matches, forcing the user to use many keystrokes (or worse: reach for the mouse :)) to choose a match. I suppose this change of behavior is intentional, consistent with all other cross-references, and only affects ergonomy; the patch more importantly restores the functionality that was previously lost. -- Ludovic Brenta.