From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#25105: 26.0.50; diff navigation is broken Date: Fri, 6 Jan 2017 17:14:39 +0300 Message-ID: References: <87inpt6lce.fsf@gmail.com> <87tw9dc7bk.fsf@secretsauce.net> <87shoxc70l.fsf@secretsauce.net> <20170106030606.GB1101@holos.localdomain> <87lguovn5f.fsf@secretsauce.net> <83mvf4d3m9.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1483712116 13273 195.159.176.226 (6 Jan 2017 14:15:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Jan 2017 14:15:16 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: mvoteiza@udel.edu, 25105@debbugs.gnu.org, Dima Kogan , npostavs@users.sourceforge.net To: Tino Calancha , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 06 15:15:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPVIR-0002ab-PP for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jan 2017 15:15:07 +0100 Original-Received: from localhost ([::1]:53020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPVIW-0007ic-0r for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jan 2017 09:15:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPVIP-0007hK-2J for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2017 09:15:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPVIL-0001eF-T0 for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2017 09:15:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57406) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPVIL-0001e0-PF for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2017 09:15:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPVIL-0003ZU-Kf for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2017 09:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2017 14:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25105-submit@debbugs.gnu.org id=B25105.148371208813693 (code B ref 25105); Fri, 06 Jan 2017 14:15:01 +0000 Original-Received: (at 25105) by debbugs.gnu.org; 6 Jan 2017 14:14:48 +0000 Original-Received: from localhost ([127.0.0.1]:44572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPVI8-0003Ym-9J for submit@debbugs.gnu.org; Fri, 06 Jan 2017 09:14:48 -0500 Original-Received: from mail-lf0-f68.google.com ([209.85.215.68]:33277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPVI6-0003Ya-VG for 25105@debbugs.gnu.org; Fri, 06 Jan 2017 09:14:47 -0500 Original-Received: by mail-lf0-f68.google.com with SMTP id k62so3393348lfg.0 for <25105@debbugs.gnu.org>; Fri, 06 Jan 2017 06:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=udfseOqcK6mlFfr7uRjWytJCcanxuo73LYwAq1u5M0w=; b=j6TEGfxZDXKHJjgypMWOffZxapg1RqxjD631aG94qK9L9XNCiNpcQdjB5WBYFdHfma ulZrhOhxYX4qGsKeoasWUiK7b8FClNwXy9P+pdqEly1B26DAuI5B9+w+3nxImYbeGEhB Og5LRkCgn8ZVzznsWoOTnVhiL8hNzCpr8cCM5h1pOLrPddcdXeWyAkM65LO/usXUHDmL QYk9+oIfLH/mhusWl7IG6IosfQUDQZGy4E01InBs1T6KuAtUYGeHs3btxJVSxxNfochf N4c3uRxQIh0kDsa2tONV3uYtSIAu4RR1AuN0CbLkJnWLvHtWW5LOBr7V5JZ4plwoDDQF uo7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=udfseOqcK6mlFfr7uRjWytJCcanxuo73LYwAq1u5M0w=; b=LvUCKuE+X3mNfaOjbebrtbXY9EIGJZmgqjgpODtGdmI7JWOgfGDJKruvG7jGw//Rgg uq5RPPLY3ZVpfmy9/jYyZHHG74IUugjvkQJwjLg0seuD43XVboTkLQa+3SIkfY0tdeS4 Kpx1zOkUuhsbRwaFLMRuL5yH0LaFkd34tOsJeMBFPry3PFxRcRPxn/Glz+S64GsjrCQ2 0Pb6UpCtii8R+KEz2UJoFUZLc9jvZQPK8a9UcewX4Z2UhUfihQ6jH5S0XtDN2uLCOO5R MLbN4iCWKuy/XOQD4VeTPWne69YcctTdP7Fz6eWj1HQ/9agn33rOErMDpOK1qL05nRaM zdtw== X-Gm-Message-State: AIkVDXJTuEMdoapPe549suDyi5qxw9bhglbfy9V+q2dPAP6auf7eRy4f3ZboIG/bfQQAOg== X-Received: by 10.25.19.170 with SMTP id 42mr22573609lft.174.1483712081056; Fri, 06 Jan 2017 06:14:41 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id v26sm230346ljb.14.2017.01.06.06.14.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jan 2017 06:14:40 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127836 Archived-At: On 06.01.2017 11:03, Tino Calancha wrote: >> Another alternative is to have a customizable option which will let >> users decide what behavior they want. > That would be OK. I would suggest to set this option nil by default, > i.e., disable the new feature by default for backward compatibility. If separating behavior into two parts that are controlled by a switch would be feasible (I'm not sure), it might be okay. However, the new behavior also fixes what was undoubtedly a problem: When point is a bob in a diff-mode buffer, `C-c C-a' applies the first hunk, and then stops at its beginning (in Emacs 25 and earlier). We would then give up on that fix, whereas I'd prefer to have a solution eventually, if not now. But if we do, I estimate we might have the "old fixed" behavior encroach on the "new different" behavior in certain respects, making the code even more complex. I've honestly thought that Dima's patch's main purpose was to fix that bug. And everything else we now complain about are just implementation's side-effects.