From: Dmitry Gutov <dgutov@yandex.ru>
To: Tino Calancha <tino.calancha@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: mvoteiza@udel.edu, 25105@debbugs.gnu.org,
Dima Kogan <dima@secretsauce.net>,
npostavs@users.sourceforge.net
Subject: bug#25105: 26.0.50; diff navigation is broken
Date: Fri, 6 Jan 2017 17:14:39 +0300 [thread overview]
Message-ID: <b8e80e6d-0be8-5037-0ee8-e1dd4a714351@yandex.ru> (raw)
In-Reply-To: <alpine.DEB.2.20.1701061702210.2892@calancha-pc>
On 06.01.2017 11:03, Tino Calancha wrote:
>> Another alternative is to have a customizable option which will let
>> users decide what behavior they want.
> That would be OK. I would suggest to set this option nil by default,
> i.e., disable the new feature by default for backward compatibility.
If separating behavior into two parts that are controlled by a switch
would be feasible (I'm not sure), it might be okay.
However, the new behavior also fixes what was undoubtedly a problem:
When point is a bob in a diff-mode buffer, `C-c C-a' applies the first
hunk, and then stops at its beginning (in Emacs 25 and earlier).
We would then give up on that fix, whereas I'd prefer to have a solution
eventually, if not now. But if we do, I estimate we might have the "old
fixed" behavior encroach on the "new different" behavior in certain
respects, making the code even more complex.
I've honestly thought that Dima's patch's main purpose was to fix that
bug. And everything else we now complain about are just implementation's
side-effects.
next prev parent reply other threads:[~2017-01-06 14:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 15:13 bug#25105: 26.0.50; diff navigation is broken Mark Oteiza
2016-12-04 15:27 ` npostavs
2016-12-05 15:38 ` Dima Kogan
2016-12-05 15:53 ` Dmitry Gutov
2016-12-05 16:33 ` Dima Kogan
2016-12-05 16:55 ` Mark Oteiza
2016-12-05 17:49 ` Dima Kogan
2016-12-25 6:57 ` Dima Kogan
2016-12-25 13:54 ` Mark Oteiza
2017-01-06 1:14 ` Tino Calancha
2017-01-06 1:20 ` Dima Kogan
2017-01-06 1:27 ` Dima Kogan
2017-01-06 3:06 ` Mark Oteiza
2017-01-06 3:50 ` Tino Calancha
2017-01-06 4:16 ` Dima Kogan
2017-01-06 4:43 ` Mark Oteiza
2017-01-06 7:55 ` Eli Zaretskii
2017-01-06 8:03 ` Tino Calancha
2017-01-06 14:14 ` Dmitry Gutov [this message]
2017-01-07 1:54 ` Tino Calancha
2017-01-07 2:05 ` Mark Oteiza
2017-01-07 9:51 ` Dima Kogan
2017-01-07 11:16 ` Tino Calancha
2017-01-07 22:16 ` Dima Kogan
2017-01-07 22:27 ` Dmitry Gutov
2017-01-06 3:09 ` Mark Oteiza
2017-01-06 4:22 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8e80e6d-0be8-5037-0ee8-e1dd4a714351@yandex.ru \
--to=dgutov@yandex.ru \
--cc=25105@debbugs.gnu.org \
--cc=dima@secretsauce.net \
--cc=eliz@gnu.org \
--cc=mvoteiza@udel.edu \
--cc=npostavs@users.sourceforge.net \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).