From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#43645: 26.3; emacsclient -c does not open to correct window Date: Mon, 28 Sep 2020 17:02:13 +0200 Message-ID: References: <87r1qmujmn.fsf@gnus.org> <837dsem2yv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30263"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bluetrack121@gmail.com, 43645@debbugs.gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 28 17:03:55 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMuh1-0007gY-2Z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Sep 2020 17:03:55 +0200 Original-Received: from localhost ([::1]:54296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMugz-00020Y-PV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Sep 2020 11:03:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMugB-0001yJ-J7 for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 11:03:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMugA-0001ZC-Bg for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 11:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kMugA-0008PG-8h for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 11:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Sep 2020 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43645 X-GNU-PR-Package: emacs Original-Received: via spool by 43645-submit@debbugs.gnu.org id=B43645.160130534432270 (code B ref 43645); Mon, 28 Sep 2020 15:03:02 +0000 Original-Received: (at 43645) by debbugs.gnu.org; 28 Sep 2020 15:02:24 +0000 Original-Received: from localhost ([127.0.0.1]:53745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMufY-0008OQ-6g for submit@debbugs.gnu.org; Mon, 28 Sep 2020 11:02:24 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:39975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMufV-0008OB-Uc for 43645@debbugs.gnu.org; Mon, 28 Sep 2020 11:02:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601305335; bh=Z9IVVCJHfC6qrnvQrnh9gMfXT4SACoqULyHQ64QK7uE=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=OG2Xpl54D9VChDa3FK/WhBSBNee0WM9a5hYwp2fFKsF2KrSCrZd3UsbnRnUmaceiq 6E7cV7RrdRfx2wxy8TbBdYb1mvgh2TeaLWmiUtS9XMDJHJRR52nN3HhIqD3cbIckaD VLX2DsIBHTt/ertd07GrMVdWqoR+56/kpEn4cH6s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([46.125.249.25]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M9Wuq-1kJbH83Iiy-005WPw; Mon, 28 Sep 2020 17:02:14 +0200 In-Reply-To: <837dsem2yv.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:R1pJEr37m41Ru3xsg8mmLPb2kK2cw8iTt3cqPKq3FrvlBrxdw5e kxPnZOsmxNaaHoIMs3ob62N4OmAHcWs/jDNySgXrm35Qd0Pu0wyfE1qoZxBVhTmgvNaiVcw 1QFHxvHZmMHOvdMb/I8aAj4sp5KN+Y10BQbt6wbs+1M6gT5pPVn3ZEbNnNzffRdTH7Jo5nm atFVQG4kAgnE1Kro9KPOw== X-UI-Out-Filterresults: notjunk:1;V03:K0:iGOYk5Ou/eo=:xZCdbEoOb1HmLymG4TQ92l br4J1Dv3RXCTvVWHDVklnQ2vqOD5bR0ln0A7dwgAMSeCEtPpqy8sn3w0hCa3N6KMRW9FIlX2P lFTK/EarPcU7ZjpE6vCf6recoYvoKsBTPKey4bsxVjlje6RMDAQ0VNfNbgrJ+NWnucz/aPIv3 Ugf3aGknfQBbqxdmQ3iy5vbl1/2CT1HMCGcaxsr3HeQNMV/to4JmZi3EjdPvaPZtOWbuHpUBR O6ixfSLLAYoQgOnWJm5v8bl5CPtXLuDyBIAy6F5EcTqRjaVg5LA0rRKssW3orhVxMYZuwr3Hq YRrW6wiZpvIr5cR2YiPyQZAfpjxvYjR9CqhNnJJAYNfrMZDgd8BCdkoVBRuZxWxt0TFy6Qerz pnxw+Hc77bwmFFCSWQUjLUARg2Lqsd618uM3qtlrK8QYN+gzD13dBH6E3zY7c7z4aTTB8AYGp KyhGbMRD/sLuiokoI/GL+IaM1ayGHBuQRBu5LBgjjlC48zmtFT9ZSBfrrLTyatNXJVSMVobRL wbAIWdcU7ckWqu/gXj2Ixv6Td5mid4BXSkcdyVkCndAe9G8uu6KQNwPnN9ERdRclKm8bfCTW3 jm1sM6HQGT38J+9pgpecJY4WFxelfNPq2AD1r5EikJN6BDALghd7vJuQj6KSV/Tl9m7zC40J5 iGfl2c0LQ42wC1r1URxPi57KBrwLjamAI12S87FLixSQ9edwuRFvHI4Sa5rf/jDR3z0at5F4z IVk2+2yrJUxQBEwh/++ck9+oL1EAx/QBVOmNOdyavNFcLXgFq8aIyb6VqGrZ9drkvSWShR8q X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189209 Archived-At: >> diff --git a/lisp/server.el b/lisp/server.el >> index 436a6ca0c7..f24f8d2b7c 100644 >> --- a/lisp/server.el >> +++ b/lisp/server.el >> @@ -1602,7 +1602,7 @@ server-switch-buffer >> ;; OK, we know next-buffer is live, let's display and select it. >> (if (functionp server-window) >> (funcall server-window next-buffer) >> - (let ((win (get-buffer-window next-buffer 0))) >> + (let ((win (get-buffer-window next-buffer))) >> (if (and win (not server-window)) >> ;; The buffer is already displayed: just reuse the >> ;; window. If FILEPOS is non-nil, use it to replace the >> > > Martin, any comments on this? Wouldn't the "0" make sense when invoking emacsclient without an option like -c or -t? IIUC, in that case we should try to reuse some existing visible or iconified window. But ... I never use emacsclient. martin