From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' Date: Thu, 30 Jun 2016 20:07:51 -0700 (PDT) Message-ID: References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1467342567 8822 80.91.229.3 (1 Jul 2016 03:09:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Jul 2016 03:09:27 +0000 (UTC) Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 01 05:09:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bIopM-00057M-NO for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Jul 2016 05:09:12 +0200 Original-Received: from localhost ([::1]:53462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIopM-0006eJ-2w for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Jun 2016 23:09:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIopF-0006dz-QW for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2016 23:09:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIopC-00026L-Gi for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2016 23:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIopC-00026H-D6 for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2016 23:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bIopC-0004hf-6g for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2016 23:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jul 2016 03:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 19362-submit@debbugs.gnu.org id=B19362.146734248518012 (code B ref 19362); Fri, 01 Jul 2016 03:09:02 +0000 Original-Received: (at 19362) by debbugs.gnu.org; 1 Jul 2016 03:08:05 +0000 Original-Received: from localhost ([127.0.0.1]:32968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIooH-0004gS-2j for submit@debbugs.gnu.org; Thu, 30 Jun 2016 23:08:05 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:46945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIooF-0004fx-G9 for 19362@debbugs.gnu.org; Thu, 30 Jun 2016 23:08:03 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6137upW023989 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Jul 2016 03:07:57 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u6137tWS022320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Jul 2016 03:07:55 GMT Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u6137q3u014989; Fri, 1 Jul 2016 03:07:54 GMT In-Reply-To: <87poqyi05f.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120247 Archived-At: > >> Do you have a list of things that you think should be aligned? > > > > No, but diff of the source code should show it. ;-) >=20 > I tried diffing pp.el and elisp-mode.el, but it was unenlightening. > Like this bug report. Yes, well, it's quite difficult. Some of the code from lisp-mode.el was moved to elisp-mode.el. And then it was modified, in some cases radically. Dunno why, except that some of the changes seem to have involved integrating eldoc. But most of the changes presumably do not concern this bug, which is only about the part of lisp-mode.el that had functions that correspond to pp.el functions.) =3D=3D=3D> The starting point is `eval-last-sexp', which used to correspond directly with `pp-eval-last-sexp'. The former was (presumably) improved, but the latter was not modified similarly. Some functions were renamed to add the prefix `elisp-' or `elisp--' (e.g. `elisp--preceding-sexp', `elisp--eval-last-sexp', `elisp--eval-last-sexp-print-value', `elisp--eval-last-sexp-fake-value', `elisp--eval-defun-1', `elisp--eval-defun'), so knowing that can help. In some cases they were just renamed. In other cases the code was changed quite a bit. But again, this bug is only about the pp-like code. This is not something you will understand in 5 minutes. It likely requires understanding the changes that were made to `eval-last-sexp' and its supporting functions, and then doing the right thing (not necessarily exactly the same thing) for `pp-eval-last-sexp'. The pp.el code was slightly different from the Emacs 24.4 (and prior) lisp-mode.el code (different helper functions, and one does not involve pretty-printing), but they generally mirror one another. Using their former correspondence as a guide should help. I cannot help more than this. It is unfortunate that the person who changed the non-pp version did not think to act similarly for the pp version. I discovered it late, myself. Once things are properly understood, perhaps the code fix will be minor. Dunno. With luck, you will find and understand the changes made to `eval-last-sexp' as a straightforward improvement that do not involve all of the other changes from lisp-mode.el code to elisp-mode.el code. With luck, perhaps the person(s) who made the changes to the non-pp code can look at this bug. No doubt that would be easiest.