From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#49248: 28.0.50; read-from-minibuffer returns a window-live-p error when its original window is deleted Date: Tue, 29 Jun 2021 10:03:11 +0200 Message-ID: References: <8735t2h46e.fsf@posteo.net> <87a6na5ibc.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38949"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49248@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 29 10:04:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ly8j4-000A0I-Lr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Jun 2021 10:04:10 +0200 Original-Received: from localhost ([::1]:53994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ly8j3-00031N-NI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Jun 2021 04:04:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ly8iw-000308-RA for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 04:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42010) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ly8iw-0002HQ-JR for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 04:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ly8iw-00010p-6S for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 04:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Jun 2021 08:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49248 X-GNU-PR-Package: emacs Original-Received: via spool by 49248-submit@debbugs.gnu.org id=B49248.16249538023845 (code B ref 49248); Tue, 29 Jun 2021 08:04:02 +0000 Original-Received: (at 49248) by debbugs.gnu.org; 29 Jun 2021 08:03:22 +0000 Original-Received: from localhost ([127.0.0.1]:53556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ly8iI-0000zx-6s for submit@debbugs.gnu.org; Tue, 29 Jun 2021 04:03:22 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:37353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ly8iF-0000zj-Tz for 49248@debbugs.gnu.org; Tue, 29 Jun 2021 04:03:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1624953793; bh=3O1mM+IqSZ2DHua0Q9RoNQZApaIWmNS4XVAdUjzp4Z0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Nk/mrZlUEG+Ph138w2S/P6edNawx5NzNgiNpL7yET4CumbMhHVoMNc152bjLPPT/q DlnQhGrFWNPewA7oRxBZvQBvVSVSyF4ZgA2Y+HnLv9XQ5ZXTXDlyfeGVLHnRh8ShAn PJqEETkydgmnzBgOK0bRDOffg1PpUIPaZZ6JML1k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.38]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MeU0k-1lPuM840hw-00aWiA; Tue, 29 Jun 2021 10:03:13 +0200 In-Reply-To: <87a6na5ibc.fsf@posteo.net> Content-Language: en-US X-Provags-ID: V03:K1:EUvTfIIqHWXqLwpQHRpLhT15BrYkUu0qYPlaAlfVisdxnYJaRU1 VHoWnhUbVEtpY9d3CSwmP2/JSjUjYcZB8aULTStR3wZIE2Ab50YM86cbED8iqTO4HtzGP3y xyZocYhdTHVbPwKOD0F9JuhX7c7h/WIO1qTpYhNr98W851twLBuHjQ+XpKYDNMB4kfHM08W m26hP7nMIgNkeg/TJcz3g== X-UI-Out-Filterresults: notjunk:1;V03:K0:QgCNVWlR4I4=:RXPzPrSvKmPUfPguVPUhhy 9Ch6exKTG91epikXN10zx5nNwdRIprlt7WRRGwvHPeypdbze9HgxzayILYTY+bvycLvha/ZUu H7vfn0plbhddXib7fxV8GlwxxyU9MlotgY9qLH8rWoQSh3mUFmpOi35BFwTZwFMH5yekJObat FrlAH4W4N+k6rHYv6NaL3/yQPoy3pnMo60uXK/L6JmaBWpFvluIl+uHbaPaajUw/uka1xRnT0 /8A0QdkwyrnTaFZA9hebJ5WiY2yw9BHsJ2qFx7KQoTGUBA+ECQfI78ro7LRxN8Kk6OMyQCieP 3KRkSiMbo6njXJrWVoqsORX2ZoXOtUuPJj6/a617Q2RfKnslNUEg/AAKu6srTF+dYaqSwfWL5 iMGQfdpGCvWgrBWgCDLu+4gP1U8gql5Wi8NH5Oo/zuTdlZgrinlazY2iVlDqHkQB9oqLAh2dv bo3oBsjhU4J3vsCfuo00lpxy/nels1R+ImlTjYgNLlQrxu7dPDh+XMKpkqlZANiN5qQ+EmdXR ydG0Dto+213vj6AI+hHnaGsQYUb/xGqEnUrJ0XmlsA30tHgwWeImu1H/luB7VDVdDnP+Adx52 t/g0p6eA6pjmtAsw8QxL6KavcjNTdNK4wkYlSgJ5HkKHzBmpagluG1wJF/b/UB4789X3L82cM 6tgokbxVsbhoW1+yvgnF3kggHsSjfVXv0PouqhepSX/hxRwa+AJ/D2JFou1RPaw5MGVqSKfLo vJ6SDnlWVczv7hw0YlqbRA6/QEIW/VHcsRNl3p6JO5xpLCI07HNzjTu3WMlDp+eJIv0/37b0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209087 Archived-At: > Thanks Martin for quick answer and fix, yes it is now working. Pushed to master now. Apparently, exiting from the minibuffer may select a frame no less than four times here: #1 in read_minibuf_unwind if (!EQ (exp_MB_frame, saved_selected_frame) && !NILP (exp_MB_frame)) do_switch_frame (exp_MB_frame, 0, 0, Qt); /* This also sets minibuf_window */ #2 in read_minibuf_unwind else if (WINDOW_LIVE_P (calling_window)) Fset_frame_selected_window (calling_frame, calling_window, Qnil); #3 in read_minibuf_unwind /* Restore the selected frame. */ if (!EQ (exp_MB_frame, saved_selected_frame) && !NILP (exp_MB_frame)) do_switch_frame (saved_selected_frame, 0, 0, Qt); #4 in read_minibuf if (FRAMEP (calling_frame) && FRAME_LIVE_P (XFRAME (calling_frame)) && (!EQ (selected_frame, calling_frame) || (WINDOW_LIVE_P (XFRAME (calling_frame)->minibuffer_window) && !EQ (XWINDOW (XFRAME (calling_frame)->minibuffer_window) ->frame, calling_frame)))) call2 (Qselect_frame_set_input_focus, calling_frame, Qnil); These will confuse the hell out of any window manager (and of me). Can some knowledgeable soul tell us what all this code is supposed to do and whether it could be refactored in some sane way? Many thanks in advance, martin