From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#30285: dired-do-chmod vs. top line of dired Date: Mon, 29 Jan 2018 15:42:59 -0800 (PST) Message-ID: References: <87mv0wg80c.fsf@jidanni.org> <87efm8snnr.fsf@gmail.com> <83efm8irac.fsf@gnu.org> <87d11sl08v.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1517270366 8321 195.159.176.226 (29 Jan 2018 23:59:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Jan 2018 23:59:26 +0000 (UTC) Cc: 30285@debbugs.gnu.org, jidanni@jidanni.org To: Tino Calancha , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 30 00:59:22 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egJKP-00018U-G2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jan 2018 00:59:09 +0100 Original-Received: from localhost ([::1]:49923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egJMQ-0001f1-DU for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jan 2018 19:01:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egJMI-0001ca-LZ for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2018 19:01:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egJMF-00028w-IM for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2018 19:01:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egJMF-00028f-FY for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2018 19:01:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1egJME-0002pK-75 for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2018 19:01:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2018 00:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30285-submit@debbugs.gnu.org id=B30285.151727043810830 (code B ref 30285); Tue, 30 Jan 2018 00:01:02 +0000 Original-Received: (at 30285) by debbugs.gnu.org; 30 Jan 2018 00:00:38 +0000 Original-Received: from localhost ([127.0.0.1]:48359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egJLq-0002oc-H1 for submit@debbugs.gnu.org; Mon, 29 Jan 2018 19:00:38 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:45142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egJLo-0002oO-Is for 30285@debbugs.gnu.org; Mon, 29 Jan 2018 19:00:37 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w0TNvO51046173; Tue, 30 Jan 2018 00:00:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=zQc5t7PLNN1pkJU01PM7vYzHsjA2pwWA7uo2DHjZg4I=; b=nxk21dkUz+wYOQDDCTqL6o/160yULSElUnD6cPEElnRGwo5psAw4fCWGz5nUQ9F1nrt+ Oucfgj+CO816SSLmdNdvCGtJpc1wk0/HrefUERqwoyM7l5BYjXIu37woyFbGF3sokg+Z U9kdtx9qxO+teLat+ABoIbuuV/kO+qaUaVuxKR4BS1dlpdRW/37NSmsxxpFSG+DnlWw8 OhS3gdsRjfr1aIOzcqrPu6gZyl33teiW8kUt/tv2q0Kr89DF5VLHHR1HNPDSezjBBgAv D3iYz7N3CmUvwNfEYSuoch1Do3GOZDqb3x4EgS8XZeBxHu5FZvgCmGiqPZuExM7zZqVX 0w== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2ftdmtr253-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jan 2018 00:00:30 +0000 Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w0TNh404012816 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 29 Jan 2018 23:43:05 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w0TNh1hl006969; Mon, 29 Jan 2018 23:43:01 GMT In-Reply-To: <87d11sl08v.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4639.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8789 signatures=668655 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=977 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801290304 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142674 Archived-At: > >> > (Why doesn't it just complain "can't operate on" like it does for > the > >> > third line, ".".) > >> Following patch just do nothing in these cases. That's OK for me. > >> Do you prefer to inform the user in this case that there is no file > >> to change the mode? > > > > Yes, I think we should produce some message in these cases. > OK. Then, we must adjust other siblings commands (dired-do-chgrp, > dired-do-chown); otherwise they might become jealous. > I propose to add a new predicate > `dired-marked-files-or-file-at-point-p', and used it in all those > commands. Please don't do any such thing. Yes, it makes sense for such commands to do nothing or to show an error message when on the "top line of dired", as described in the bug report. No, we don't need a function `dired-marked-files-or-file-at-point-p', for that or anything else. The `dired-do-*' commands already DTRT wrt the marked-files-or-file-at-point. And no, it doesn't make sense to act that way on `.' - it's OK to change the properties of the current directory (provided you have the necessary permissions). And that's not even part of this bug report, is it? The question of `..' is arguable, but I'd say the same thing for it as for `.': It's OK to change its properties, provided you have permission to do so. After all, `..' is just a (unique) directory. How did this bug report move from being about behavior on the top line (and the second, "total" etc. line) to being also about the lines for `.' and `..'?