From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67061: [PATCH] Improve syntax highlighting for python-ts-mode Date: Mon, 1 Jan 2024 19:42:16 +0200 Message-ID: References: <8734xdni6y.fsf@yandex.ru> <831qcwycbj.fsf@gnu.org> <83v8a3qh6m.fsf@gnu.org> <834jhadvkt.fsf@gnu.org> <7aee7e42-c07d-9131-18a9-4806f07d4267@gutov.dev> <83a5qw7izt.fsf@gnu.org> <172531702081590@mail.yandex.ru> <212931702208489@mail.yandex.ru> <0c6e2e14-b494-a8cb-3893-ffb39577baf9@gutov.dev> <7b17c99d-6e4b-43b3-af93-993901a3a4ea@gmail.com> <95071702343720@mail.yandex.ru> <78ffdcf3-e322-49ea-a0d5-d0485ade9e73@gmail.com> <7371702772641@mail.yandex.ru> <27502181702944649@mail.yandex.ru> <16489c3d-bddf-984b-6c98-2a1de9fdb6e8@gutov.dev> <43841703366539@mail.yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38407"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: "67061@debbugs.gnu.org" <67061@debbugs.gnu.org> To: Denis Zubarev , Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 01 18:43:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rKMJl-0009jd-U7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Jan 2024 18:43:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rKMJb-00087d-1T; Mon, 01 Jan 2024 12:43:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKMJY-00086s-WA for bug-gnu-emacs@gnu.org; Mon, 01 Jan 2024 12:43:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rKMJY-0004SQ-Lo for bug-gnu-emacs@gnu.org; Mon, 01 Jan 2024 12:43:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rKMJa-0001xR-HQ for bug-gnu-emacs@gnu.org; Mon, 01 Jan 2024 12:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Jan 2024 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67061 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67061-submit@debbugs.gnu.org id=B67061.17041309497476 (code B ref 67061); Mon, 01 Jan 2024 17:43:02 +0000 Original-Received: (at 67061) by debbugs.gnu.org; 1 Jan 2024 17:42:29 +0000 Original-Received: from localhost ([127.0.0.1]:48702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKMJ3-0001wW-93 for submit@debbugs.gnu.org; Mon, 01 Jan 2024 12:42:29 -0500 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:46971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKMJ1-0001wH-OF for 67061@debbugs.gnu.org; Mon, 01 Jan 2024 12:42:28 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 89B043200C3D; Mon, 1 Jan 2024 12:42:19 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 01 Jan 2024 12:42:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1704130939; x=1704217339; bh=DfzNjIUT+Gy6dZCcmszb8gZWkkQIEsFhZHFAWYZNHrU=; b= J6eGWEvR/yXEigyeuhLjuhZ+pfWI20P4jManqZygh/sVb8lVcPsWSerQe4PNztVW U9A9OrgIWTn8kT0DpWEia3IFoSdUz0vaHefqaGRb8AH3Hum+7eieAe4/md5e4UV0 OBng2U27wqE0wJqLUfy4ImAsQjLEPybn8/IA87Tv46qJvYNRpDoUGVUkDWEqE6mc 4DQv7Glk7HCuKX7Y5rHKtCJaeZHW/xGOX5zCkT/p5p6gOj44Xo9iRo/iKAykk1pt GDbTdMcpcyS4su0DYj7+CqeKQD3+YkQXiHIz8cIi7VKxVRB44a3iXVIKhQuJBVQn Y0eA8L4Yu136hEG1M2kdQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1704130939; x= 1704217339; bh=DfzNjIUT+Gy6dZCcmszb8gZWkkQIEsFhZHFAWYZNHrU=; b=a ivJOuSE+t6IVHZvND/W+6eWeleOs9C0riyj54foxyPg3O1RxbuZQBhFmVB/BG/Ty zkjeQtGB6TR8yD2XunFoCghhVaQTao9+s+nPETL079zdJXw9n1d1mZHab6slXbWs kgeRvaEbP1sAozq/ZYU5506mLRINUWcIpCSc+YwPJr/5/S6tYTn/zDh25IhTw49s 77EgU5C3rd6Me1owuRGcaPabB58n6boQlBO1cDtmgFmkXapgS9g1xSkBDIcnLIgK PnmOd0g4m86LpbGa87RYqHL+9L0xji0W8GVZIRUKV3hT0c3ZSi8hxOICLqXDAr9j wBEMACANHp+Gqv5IGwuFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdegtddguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 1 Jan 2024 12:42:17 -0500 (EST) Content-Language: en-US In-Reply-To: <43841703366539@mail.yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277187 Archived-At: On 23/12/2023 23:45, Denis Zubarev wrote: > Just adding a rule for highlighting CamelCase identifiers as types would > lead to many false positives. For example, global variables or an object > instantiation. It seems like the convention is to use ALL_CAPITAL for constants and CamelCase for classes/constructors. Those can be distinguished with a regexp, with single-char names being sorted into constants, which they usually are. I suppose some code could be violating that, but perhaps we should remind such authors about that with highlighting as well. Regarding object instantiation, I'd be happy to see the class name in Class(...) instantiation calls highlighted with font-lock-type-face. that's more useful that telling the user that they are seeing a function call by the means of font-lock-function-call-face.