From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#56613: 29; minibuffer-complete-history throws an error for minibuffer-history-variable=t Date: Mon, 18 Jul 2022 19:27:18 +0200 Message-ID: References: <86bktna9zo.fsf@mail.linkov.net> <86wncayjaw.fsf@mail.linkov.net> <5646a09b-6360-2290-d0c9-671c8216ad69@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34875"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56613@debbugs.gnu.org, Juri Linkov To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 18 20:04:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDV6x-0008dD-2S for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Jul 2022 20:04:51 +0200 Original-Received: from localhost ([::1]:32964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDV6w-0006Ef-5z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Jul 2022 14:04:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDUXK-0005XQ-Qj for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2022 13:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54220) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDUXK-0002aC-F3 for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2022 13:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDUXK-0003YQ-6G for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2022 13:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2022 17:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56613 X-GNU-PR-Package: emacs Original-Received: via spool by 56613-submit@debbugs.gnu.org id=B56613.165816525313625 (code B ref 56613); Mon, 18 Jul 2022 17:28:02 +0000 Original-Received: (at 56613) by debbugs.gnu.org; 18 Jul 2022 17:27:33 +0000 Original-Received: from localhost ([127.0.0.1]:51979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDUWr-0003Xh-3F for submit@debbugs.gnu.org; Mon, 18 Jul 2022 13:27:33 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:34845 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDUWm-0003XP-Bo for 56613@debbugs.gnu.org; Mon, 18 Jul 2022 13:27:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=upU5jh2QPCGKzxQUT44STLosl/yIuf76cfMTcOXyKes=; b=ADRAmv2EQqbCr8MdO4sEyhOxIY Uht5ssrHBYYPZmq19Mf1y+yfBel1x3SakIjEFXdQP9gshrmp/v45NeWfeuue3LFHa2i1XpckI4od5 jbeIHE7x3oWGfhcUAyIY3V3eSP6Wh1v7YQ66s3Cg7qvuTVZTkIZbZvivDTpCeJfc8x3w=; Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237377 Archived-At: On 7/18/22 18:19, Stefan Monnier wrote: >>> I think the long-term direction is clear: `completion-at-point` should >>> be used not just "in buffer" but in the minibuffer as well. >>> We could start that journey by making use of it for CRM. >> >> Not sure if I agree with this in full generality. The question is if you >> define completion only as completion of text or if you also accept the >> selection paradigm, where are a bunch of candidates are offered and >> filtered. The selection paradigm is used in most popular applications >> (web browser history, form filling). In Emacs we have Icomplete, Ivy, >> Vertico, etc. which implement that paradigm. > > I wasn't careful enough in what I wrote. I didn't mean to say that CRM > should use the `completion-at-point` UI, but that it should rely on CAPF > as the way to complete each element. Oh, I already agreed that Capfs could work for CRM behind the scenes. However I would be careful to not violate the abstraction barriers too much, which we have in place right now. In the end the completion table has to be passed through completing-read or completion-in-region to the frontend. (completing-read-multiple installs its crm--choose-completion-string hook, which is not great. But besides that, it is kind of nice that completing-read and completing-read-multiple just work as is with Vertico. Vertico doesn't have any kind of CRM special casing.) Daniel