From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#54486: 29.0.50; Eshell `escaped' string property can "leak" into output Date: Mon, 21 Mar 2022 12:24:09 -0700 Message-ID: References: <4246ce24-e48e-4bdf-4918-412bf6c0e595@gmail.com> <834k3rfqfk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14105"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54486@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 21 20:25:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWNex-0003XZ-GG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Mar 2022 20:25:43 +0100 Original-Received: from localhost ([::1]:40754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWNew-0005dL-EH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Mar 2022 15:25:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWNeJ-0005cT-5F for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 15:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWNeI-0001GR-PB for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 15:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nWNeI-0005Yt-LO for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 15:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2022 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54486 X-GNU-PR-Package: emacs Original-Received: via spool by 54486-submit@debbugs.gnu.org id=B54486.164789065921323 (code B ref 54486); Mon, 21 Mar 2022 19:25:02 +0000 Original-Received: (at 54486) by debbugs.gnu.org; 21 Mar 2022 19:24:19 +0000 Original-Received: from localhost ([127.0.0.1]:38334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWNda-0005Xr-S3 for submit@debbugs.gnu.org; Mon, 21 Mar 2022 15:24:19 -0400 Original-Received: from mail-pf1-f178.google.com ([209.85.210.178]:35615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWNdY-0005Xf-Ub for 54486@debbugs.gnu.org; Mon, 21 Mar 2022 15:24:17 -0400 Original-Received: by mail-pf1-f178.google.com with SMTP id a5so16388141pfv.2 for <54486@debbugs.gnu.org>; Mon, 21 Mar 2022 12:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=KTGxpTWmFj7yeq0R3qQ7IQJP4jNArnjlQBMU3wfN7Cw=; b=Y1WkOYGEju0mTYtUG/rHH2odf06nPlQO/7WW9MHMlieCeiz6guq7e/tM3ntTuyMeAz DiPcgcJhImge/XOdHitZdLdIuhdZeocq9PYkc0cwePg+Ro1gMmpOGHIlBITL37mqzCML cRMDos7/tEOJgD7dnHJnTQz6jRTzHv4e4v5S5b9BXqwR4IG0gkVN5m9unWYr0phLNEly oqFGP/xXTbPz7rUgwcIuOIDm/dnguyLQLAs7XfcDqYvM3OQxkwGns48fJLH9fgRvp47C W9SJwmnefFyZhaNa6iev3PrXckBn6q8WnnV2vZboSkHPDsux2KApFXFzg758V2/IexzD Bq5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KTGxpTWmFj7yeq0R3qQ7IQJP4jNArnjlQBMU3wfN7Cw=; b=2vAypq8gqP0jrxuM8i+6sHyYBJhcizRrrMcWl9yWsnMHkJUDr7D0bA1uIPDi6qQ/db YsuP/sZZx36nxf/qV5Tcier4kN7CXUvgAsh22PH9rOkslYgE/HJ51JfEAKfE9hG3reJc wRNBB+pQMkPbjzCI3Io2ICLzq03fcj2ittF+wCr4/n1VUj2iUZ6BR3yNWe0s7tsmiP9W OTrJV6EwAhRYgNpIfFtE9QfVQ8FQpTUMc+s9jWuCU6KGB3Qez8Sko5yU0PbV7V/OG1bO OFMCgjWQfepFkRifPnqLDonTU822ybXiRQ/5ZGcIUHirlQ8BqnI4wcJpxneq3PRrt3Rb q9fw== X-Gm-Message-State: AOAM533lYP9hmnIXWam19qzlWzXp8oFiodANmNm4HdVtDuXYxAlrC1CC XaSV4qrUeWgBm4tzLehhG8z99HkYEC8= X-Google-Smtp-Source: ABdhPJyveZb1IfmOqetMVw9KQEbCdEHje47z76Bs6Z/QH+a6L75+bqUxVZ9xzSvSl9/C5GUFIRPRzA== X-Received: by 2002:a63:d306:0:b0:34e:4330:efea with SMTP id b6-20020a63d306000000b0034e4330efeamr19236667pgg.174.1647890651100; Mon, 21 Mar 2022 12:24:11 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c11-20020a056a000acb00b004f35ee129bbsm21864393pfl.140.2022.03.21.12.24.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 12:24:10 -0700 (PDT) In-Reply-To: <834k3rfqfk.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228713 Archived-At: On 3/21/2022 5:19 AM, Eli Zaretskii wrote: > Why exactly do you think this should be fixed? I don't think I > understand that from your description. We have many features that add > text properties to strings, so why is this one different? About the > only thing I can think of is to add this property to the default value > of yank-excluded-properties, but that's all. I didn't know `yank-excluded-properties' existed. I think that would be a good thing to use for this. Besides that, I think it would be best if Eshell didn't show the `escaped' property when printing things under normal circumstances. It's really just for internal bookkeeping in Eshell, so I think users are unlikely to want to see it in most cases. The best way to fix this might be to rethink how Eshell (specifically `eshell-stringify') prints lists by default. This is mentioned in bug#12689 (though that bug additionally describes an unrelated issue with Eshell subcommands that I've since fixed). Finally, maybe it would be good to change the name of the `escaped' property to something like `eshell-escaped'. It took me quite a while to figure out where that property was even coming from when I first noticed it. Technically, that would be an incompatible change, but since this property is for internal bookkeeping in Eshell, I'd be very surprised if anyone else was relying on it.