From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#50762: diff-update-on-the-fly doesn't update hunk headers while regexp-replacing lines Date: Thu, 23 Sep 2021 18:56:48 +0300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33759"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.40.4 To: 50762@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 23 17:58:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTR71-0008b8-FM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Sep 2021 17:58:15 +0200 Original-Received: from localhost ([::1]:35172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTR6z-0000xS-P8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Sep 2021 11:58:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTR6o-0000vw-Sp for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 11:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTR6o-00034N-IJ for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 11:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTR6o-0001EK-5z for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 11:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Sep 2021 15:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50762 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16324126224637 (code B ref -1); Thu, 23 Sep 2021 15:58:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Sep 2021 15:57:02 +0000 Original-Received: from localhost ([127.0.0.1]:55592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTR5p-0001Cd-NH for submit@debbugs.gnu.org; Thu, 23 Sep 2021 11:57:01 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTR5o-0001CQ-5c for submit@debbugs.gnu.org; Thu, 23 Sep 2021 11:57:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTR5n-0000ob-UB for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 11:56:59 -0400 Original-Received: from forward106p.mail.yandex.net ([2a02:6b8:0:1472:2741:0:8b7:109]:41382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTR5k-00027C-No for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 11:56:59 -0400 Original-Received: from iva3-d53c26eb10e1.qloud-c.yandex.net (iva3-d53c26eb10e1.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:4987:0:640:d53c:26eb]) by forward106p.mail.yandex.net (Yandex) with ESMTP id 08BEC2FC03FB for ; Thu, 23 Sep 2021 18:56:49 +0300 (MSK) Original-Received: from iva1-6c7d234f141c.qloud-c.yandex.net (iva1-6c7d234f141c.qloud-c.yandex.net [2a02:6b8:c0c:972c:0:640:6c7d:234f]) by iva3-d53c26eb10e1.qloud-c.yandex.net (mxback/Yandex) with ESMTP id TTgZVJXv37-umEKLgmM; Thu, 23 Sep 2021 18:56:48 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1632412608; bh=JZN00hdN4yNIPYkGb6XGIrgqlHyWGDngmeT7mP9ttnI=; h=Date:To:From:Subject:Message-ID; b=hYwMk+Ov9xEOuaE8JW4AGcRToILM9qEQKn2m5ucrTDcHm21xw6ZMlbBnpcSwrsEaF vvw5lqoNASKa6DR6s1YbjHsEVGQgzjCUm4Wqxot69J3byRMvHIQZ5T44AQXPRWyuwi hcQ5J9rrLaxzL2inCQcNtWCX68srxekmzhH4+n4w= Authentication-Results: iva3-d53c26eb10e1.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by iva1-6c7d234f141c.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id TPAoJ7ZEMD-umxOe79C; Thu, 23 Sep 2021 18:56:48 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Received-SPF: pass client-ip=2a02:6b8:0:1472:2741:0:8b7:109; envelope-from=hi-angel@yandex.ru; helo=forward106p.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215194 Archived-At: As title says. I think due to this bug it would make sense to have diff-update-on-the-fly set to nil by default. # Steps to reproduce 1. In Emacs repo, `git checkout 72f8a9dd08132119a` (arbitrary commit for the sake of testcase) 2. Create a patch from Emacs repo with `git format-patch -1 --stdout > /tmp/1.patch`, open it. 3. Note that 1st hunk has value `-2883,10 +2883,13` 4. Use regexp-replace aka `C-M-%` with `(.*^J\+.* → line1` (please replace ^J here with C-q C-j) 5. When asked for matches, press `!`, so all lines are replaced 6. Look at the first hunk again ## Expected It changes its value to recalculation that should be happening ## Actual It still has the older value, no recalculation has happened.