From: "Phillip Lord" <phillip.lord@russet.org.uk>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: 23203@debbugs.gnu.org, stromeko@nexgo.de,
Phillip Lord <phillip.lord@russet.org.uk>
Subject: bug#23203: 25.0.91; some loaddefs files have auto-save remnants after building (and install doesn't ignore them)
Date: Sun, 3 Apr 2016 20:33:37 +0100 [thread overview]
Message-ID: <b6ad1fe57340c9304d155093abc852e0.squirrel@cloud103.planethippo.com> (raw)
In-Reply-To: <83fuv2plj5.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Sun, April 3, 2016 7:58 pm, Eli Zaretskii wrote:
>> Date: Sun, 3 Apr 2016 19:46:40 +0100
>> From: "Phillip Lord" <phillip.lord@russet.org.uk>
>> Cc: 23203@debbugs.gnu.org
>>
>>
>> The attached patch fixes the problem in my hands (assuming we believe
>> that this is a bug). The solution may be a bit blunt, though, although
>> the function patched is documented as "use in batch during build".
>
> Indeed, I'd rather we didn't do anything that drastic.
>
>
> If needed, backups can be disabled from the command line.
That works too (see attached diff), although it's a bit of pain because of
duplication in the makefile.
I would ask though, when do we want backup files produced from the
batch-update-autoloads function? Changing the default behaviour of this
function seems to make the most sense to me (although perhaps not the way
that I did it).
Phil
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix2.diff --]
[-- Type: text/x-patch; name="fix2.diff", Size: 2645 bytes --]
diff --git a/lisp/Makefile.in b/lisp/Makefile.in
index f33dd01..98743e8 100644
--- a/lisp/Makefile.in
+++ b/lisp/Makefile.in
@@ -183,6 +183,7 @@ $(lisp)/loaddefs.el: $(LOADDEFS)
--eval '(setq autoload-ensure-writable t)' \
--eval '(setq autoload-builtin-package-versions t)' \
--eval '(setq generated-autoload-file (expand-file-name (unmsys--file-name "$@")))' \
+ --eval '(setq make-backup-files nil)' \
-f batch-update-autoloads ${SUBDIRS_ALMOST}
# This is required by the bootstrap-emacs target in ../src/Makefile, so
@@ -381,7 +382,8 @@ $(MH_E_DIR)/mh-loaddefs.el: $(MH_E_SRC)
$(AM_V_GEN)$(emacs) -l autoload \
--eval "(setq generate-autoload-cookie \";;;###mh-autoload\")" \
--eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
- -f batch-update-autoloads $(MH_E_DIR)
+ --eval '(setq make-backup-files nil)' \
+ -f batch-update-autoloads $(MH_E_DIR)
# Update TRAMP internal autoloads. Maybe we could move tramp*.el into
# an own subdirectory. OTOH, it does not hurt to keep them in
@@ -394,6 +396,7 @@ $(TRAMP_DIR)/tramp-loaddefs.el: $(TRAMP_SRC)
$(AM_V_GEN)$(emacs) -l autoload \
--eval "(setq generate-autoload-cookie \";;;###tramp-autoload\")" \
--eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
+ --eval '(setq make-backup-files nil)' \
-f batch-update-autoloads $(TRAMP_DIR)
CAL_DIR = $(lisp)/calendar
@@ -406,19 +409,22 @@ $(CAL_DIR)/cal-loaddefs.el: $(CAL_SRC)
$(AM_V_GEN)$(emacs) -l autoload \
--eval "(setq generate-autoload-cookie \";;;###cal-autoload\")" \
--eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
+ --eval '(setq make-backup-files nil)' \
-f batch-update-autoloads $(CAL_DIR)
$(CAL_DIR)/diary-loaddefs.el: $(CAL_SRC) $(CAL_DIR)/cal-loaddefs.el
$(AM_V_GEN)$(emacs) -l autoload \
--eval "(setq generate-autoload-cookie \";;;###diary-autoload\")" \
--eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
+ --eval '(setq make-backup-files nil)' \
-f batch-update-autoloads $(CAL_DIR)
$(CAL_DIR)/hol-loaddefs.el: $(CAL_SRC) $(CAL_DIR)/diary-loaddefs.el
$(AM_V_GEN)$(emacs) -l autoload \
--eval "(setq generate-autoload-cookie \";;;###holiday-autoload\")" \
--eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
- -f batch-update-autoloads $(CAL_DIR)
+ --eval '(setq make-backup-files nil)' \
+ -f batch-update-autoloads $(CAL_DIR)
.PHONY: bootstrap-clean distclean maintainer-clean
next prev parent reply other threads:[~2016-04-03 19:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 7:08 bug#23203: 25.0.91; some loaddefs files have auto-save remnants after building (and install doesn't ignore them) Achim Gratz
2016-04-03 8:26 ` Andreas Schwab
2016-04-03 8:28 ` Andreas Schwab
2016-04-03 8:48 ` Achim Gratz
2016-04-03 10:46 ` Andreas Schwab
2016-04-03 11:47 ` Achim Gratz
2016-04-03 13:58 ` Phillip Lord
2016-04-03 14:36 ` Andreas Schwab
2016-04-03 18:46 ` Phillip Lord
2016-04-03 18:58 ` Eli Zaretskii
2016-04-03 19:33 ` Phillip Lord [this message]
2016-04-03 19:39 ` Eli Zaretskii
2016-04-03 20:11 ` Phillip Lord
2016-04-04 15:27 ` Eli Zaretskii
2016-04-04 22:12 ` Phillip Lord
2016-04-05 18:16 ` Achim Gratz
2016-04-08 8:22 ` Eli Zaretskii
2016-04-08 15:25 ` Phillip Lord
2016-04-10 20:30 ` Phillip Lord
2016-04-12 12:03 ` Phillip Lord
2016-04-12 15:20 ` Eli Zaretskii
2016-04-12 15:39 ` Glenn Morris
2016-04-12 16:34 ` Phillip Lord
2016-04-12 16:40 ` Eli Zaretskii
2016-04-12 18:08 ` John Wiegley
2020-08-15 4:11 ` Stefan Kangas
2016-04-04 15:42 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6ad1fe57340c9304d155093abc852e0.squirrel@cloud103.planethippo.com \
--to=phillip.lord@russet.org.uk \
--cc=23203@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stromeko@nexgo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).