From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60110: 29.0.60; ruby-mode method parameter alignment Date: Mon, 19 Dec 2022 00:32:01 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------QBgd79avVZ2t0qLRyVhnrdv5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4878"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: Aaron Jensen , 60110@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 23:33:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p72Dk-00012j-75 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 23:33:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p72Da-0004v7-41; Sun, 18 Dec 2022 17:33:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p72DP-0004uO-Mk for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 17:33:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p72DO-0007vr-MZ for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 17:33:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p72DO-0008HQ-9d for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 17:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 22:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60110 X-GNU-PR-Package: emacs Original-Received: via spool by 60110-submit@debbugs.gnu.org id=B60110.167140273231809 (code B ref 60110); Sun, 18 Dec 2022 22:33:02 +0000 Original-Received: (at 60110) by debbugs.gnu.org; 18 Dec 2022 22:32:12 +0000 Original-Received: from localhost ([127.0.0.1]:36286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p72Ca-0008Gy-3T for submit@debbugs.gnu.org; Sun, 18 Dec 2022 17:32:12 -0500 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:38898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p72CX-0008Gs-Ir for 60110@debbugs.gnu.org; Sun, 18 Dec 2022 17:32:10 -0500 Original-Received: by mail-wr1-f53.google.com with SMTP id f18so7092272wrj.5 for <60110@debbugs.gnu.org>; Sun, 18 Dec 2022 14:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:to:content-language:subject:user-agent :mime-version:date:message-id:sender:from:to:cc:subject:date :message-id:reply-to; bh=aP9cDQc7qc8jhtGspmjMWfRmTysCB2luhOO1uVG7lbU=; b=fGL71GbqKnhQXM052EAvjbUF0i32X7a+q2zBJmq02HSxJX8EgpYDUuZ1IJsWLNTKY+ sezeFOQzZxOZNWdWk4gNAwa6Pm3UH1GBhtqvx/zM72myTVBgSum5Q+o5VvJ4IVSmtNKg LQEMxKWbnE0TNb7WVz0YFG9ItWv4z7l8LWDl4wWWQqFsCPVTN8kkoE+5pG9d92s96te4 8koUI4bUDwGsKpcg9imbflKh7Wdk+J86jz5sbjGibCTmloXhLwlY639DNldIJuN1LFbI Qy5eD+3Ra9ESLqZrfoi705b+Toq98Fj+JJ5HbzzaiXEwtlY7lHTWJfMJ1sFvZVqYaasy HntA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:to:content-language:subject:user-agent :mime-version:date:message-id:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aP9cDQc7qc8jhtGspmjMWfRmTysCB2luhOO1uVG7lbU=; b=cmJOS69DvdWBwiit02j/iLGx3oh1x2da8Fw8wHb/GwN7DG0vNF3OPDxrLQNAYdhL+D DtnAZ/bHQ53mgcFOZLOin8YQlXZrnXYqWO/CjKeoYLo5wiS/hrXuJrg8TcGMrcipWnql NCJZAJJ0RaTuVDrQPTmw64L52/xcRZR4dzFh1aadpdtpjMasv48Z0qJ7w9JRj+dTGO2n xxntSchFw1oDBsWxS7mTDP1g6uvrSE+S4nz+UhaMUmt5FVRqpdwIsq7BB3mEJU1utDCt woQv8C4G1Jm8HBiaBflLYa64Edd7gcp/Xk2Gg3TSPPmG6/s1pyrKNSKHoyU5pue9h3JY Bm6A== X-Gm-Message-State: ANoB5pkZ7TTaocqEXWwbI1pN9unDFTKbR0qqk8x+WZjmnI+VVZlfbkrA ttFvn+ODncrkn+Fne8f+2uo= X-Google-Smtp-Source: AA0mqf6b9Q0yLRYtJmWwDWUFj0jDOWNapJtPJ1zylToIeG5fikcuY5N2UciTDUcg4/zKuW6bMfxYzQ== X-Received: by 2002:a05:6000:137a:b0:242:4209:ea73 with SMTP id q26-20020a056000137a00b002424209ea73mr25191878wrz.28.1671402723601; Sun, 18 Dec 2022 14:32:03 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q9-20020a05600000c900b0024228b0b932sm9739888wrx.27.2022.12.18.14.32.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Dec 2022 14:32:02 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251381 Archived-At: This is a multi-part message in MIME format. --------------QBgd79avVZ2t0qLRyVhnrdv5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Aaron, Thanks for the report. On 16/12/2022 07:04, Aaron Jensen wrote: > > Currently, ruby-mode smie indents method parameters like this: > > def some_method( > some_arg, > some_other_arg > ) > end > > def self.some_method( > some_arg, > some_other_arg > ) > end I'm assuming the difference in indentation between these posted cases is just an email/bug tracker bug. If they are sometimes different, please let me know. That would be another bug. > I would prefer to be able to indent them like this: > > def some_method( > some_arg, > some_other_arg > ) > end > > def self.some_method( > some_arg, > some_other_arg > ) > end See the attached patch. (setq ruby-method-params-indent 0) should do it. > Rubocop has two rules that govern this behavior: > > Layout/FirstParameterIndentation: consistent > https://docs.rubocop.org/rubocop/1.40/cops_layout.html#layoutfirstparameterindentation > > Layout/ParameterAlignment: with_first_parameter and > with_fixed_indentation would both work. I don't have a strong opinion on > this, because I usually break after a ( if I am going to put parameters > on their own line. Leaving the first one on the same line as the method > name is not as scannable. > https://docs.rubocop.org/rubocop/1.40/cops_layout.html#layoutparameteralignment All right. It doesn't seem to support many styles, only indenting the first param against the opening paren, and against the beginning of "def". But it confirmed my idea for the option name (a generic one). --------------QBgd79avVZ2t0qLRyVhnrdv5 Content-Type: text/x-patch; charset=UTF-8; name="ruby-method-params-indent.diff" Content-Disposition: attachment; filename="ruby-method-params-indent.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggY2RlZDYwY2NhNjMuLmZk ZjAxNTkyZTEwIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMjc2 MSw2ICsyNzYxLDkgQEAgcHJvamVjdC1kZWRpY2F0ZWQgb3IgZ2xvYmFsKSBpcyBzcGVjaWZp ZWQgYnkgdGhlIG5ldwogLS0tCiAqKiogU3VwcG9ydCBmb3IgZW5kbGVzcyBtZXRob2RzLgog CistLS0KKyoqKiBOZXcgdXNlciBvcHRpb24gJ3J1YnktbWV0aG9kLXBhcmFtcy1pbmRlbnQn LgorCiAqKiBFc2hlbGwKIAogKysrCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9ydWJ5 LW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUuZWwKaW5kZXggZWQ2MDQ0Mjgw ZWEuLmQ0ZTZhMjVlNWIzIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUu ZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLmVsCkBAIC0yNjcsNiArMjY3LDI0 IEBAIHJ1YnktYWxpZ24tY2hhaW5lZC1jYWxscwogICA6c2FmZSAnYm9vbGVhbnAKICAgOnZl cnNpb24gIjI0LjQiKQogCisoZGVmY3VzdG9tIHJ1YnktbWV0aG9kLXBhcmFtcy1pbmRlbnQg dAorICAiSW5kZW50YXRpb24gc3R5bGUgb2YgbXVsdGlsaW5lIG1ldGhvZCBwYXJhbWV0ZXJz LgorCitXaGVuIHQsIHRoZSB3aG9sZSBsaXN0IHdpdGggcGFyZW50aGVzZXMgaXMgaW5kZW50 ZWQgYWdhaW5zdCB0aGUKK21ldGhvZCBuYW1lLgorCitXaGVuIGEgbnVtYmVyLCBpbmRlbnQg dGhlIHBhcmFtZXRlcnMgdGhpcyBtYW55IGNvbHVtbnMgYWdhaW5zdAordGhlIGJlZ2lubmlu ZyBvZiB0aGUgbWV0aG9kICh0aGUgXCJkZWZcIiBrZXl3b3JkKS4KKworVGhlIHZhbHVlIG5p bCBtZWFucyB0aGUgc2FtZSBhcyAwLgorCitPbmx5IGhhcyBlZmZlY3Qgd2hlbiBgcnVieS11 c2Utc21pZScgaXMgdC4iCisgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFnICJJbmRlbnQg YWdhaW5zdCBtZXRob2QgbmFtZSIgdCkKKyAgICAgICAgICAgICAgICAgKG51bWJlciA6dGFn ICJJbmRlbnQgc3BlY2lmaWVkIG51bWJlciBvZiBjb2x1bW5zIGFnYWluc3QgZGVmIikKKyAg ICAgICAgICAgICAgICAgKGNvbnN0IDp0YWcgIkluZGVudCB0byBkZWYiIG5pbCkpCisgIDpz YWZlIChsYW1iZGEgKHZhbCkgKG9yIChtZW1xIHZhbCAnKHQgbmlsKSkgKG51bWJlcnAgdmFs KSkpCisgIDp2ZXJzaW9uIDI5LjEpCisKIChkZWZjdXN0b20gcnVieS1kZWVwLWFyZ2xpc3Qg dAogICAiRGVlcCBpbmRlbnQgbGlzdHMgaW4gcGFyZW50aGVzaXMgd2hlbiBub24tbmlsLgog QWxzbyBpZ25vcmVzIHNwYWNlcyBhZnRlciBwYXJlbnRoZXNpcyB3aGVuIGBzcGFjZScuCkBA IC02NTksOSArNjc3LDEyIEBAIHJ1Ynktc21pZS1ydWxlcwogICAgICAgICh1bmxlc3MgKG9y IChlb2xwKSAoZm9yd2FyZC1jb21tZW50IDEpKQogICAgICAgICAgKGNvbnMgJ2NvbHVtbiAo Y3VycmVudC1jb2x1bW4pKSkpKQogICAgICgnKDpiZWZvcmUgLiAiIEAgIikKLSAgICAgKHNh dmUtZXhjdXJzaW9uCi0gICAgICAgKHNraXAtY2hhcnMtZm9yd2FyZCAiIFx0IikKLSAgICAg ICAoY29ucyAnY29sdW1uIChjdXJyZW50LWNvbHVtbikpKSkKKyAgICAgKGlmIChvciAoZXEg cnVieS1tZXRob2QtcGFyYW1zLWluZGVudCB0KQorICAgICAgICAgICAgIChub3QgKHNtaWUt cnVsZS1wYXJlbnQtcCAiZGVmIiAiZGVmPSIpKSkKKyAgICAgICAgIChzYXZlLWV4Y3Vyc2lv bgorICAgICAgICAgICAoc2tpcC1jaGFycy1mb3J3YXJkICIgXHQiKQorICAgICAgICAgICAo Y29ucyAnY29sdW1uIChjdXJyZW50LWNvbHVtbikpKQorICAgICAgIChzbWllLXJ1bGUtcGFy ZW50IChvciBydWJ5LW1ldGhvZC1wYXJhbXMtaW5kZW50IDApKSkpCiAgICAgKCcoOmJlZm9y ZSAuICJkbyIpIChydWJ5LXNtaWUtLWluZGVudC10by1zdG10KSkKICAgICAoJyg6YmVmb3Jl IC4gIi4iKQogICAgICAoaWYgKHNtaWUtcnVsZS1zaWJsaW5nLXApCmRpZmYgLS1naXQgYS90 ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS1yZXNvdXJjZXMvcnVieS1tZXRob2QtcGFy YW1zLWluZGVudC5yYiBiL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXJlc291cmNl cy9ydWJ5LW1ldGhvZC1wYXJhbXMtaW5kZW50LnJiCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwLi4yYjY2NTc5NzM5NwotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3Qv bGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXJlc291cmNlcy9ydWJ5LW1ldGhvZC1wYXJhbXMt aW5kZW50LnJiCkBAIC0wLDAgKzEsMTggQEAKK2NsYXNzIEMKKyAgZGVmIHNlbGYuZm9vKAor ICAgIGJheiwKKyAgICBiYXIKKyAgKSA9CisgICAgd2hhdAorCisgIGRlZiBmb289KAorICAg IGJheiwKKyAgICBiYXIKKyAgKQorICAgIGhlbGxvCisgIGVuZAorZW5kCisKKyMgTG9jYWwg VmFyaWFibGVzOgorIyBydWJ5LW1ldGhvZC1wYXJhbXMtaW5kZW50OiAwCisjIEVuZDoKZGlm ZiAtLWdpdCBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXJlc291cmNlcy9ydWJ5 LnJiIGIvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUtcmVzb3VyY2VzL3J1YnkucmIK aW5kZXggNTYzNmE0ZmMwZTIuLjYxYjc1YzBjN2YyIDEwMDY0NAotLS0gYS90ZXN0L2xpc3Av cHJvZ21vZGVzL3J1YnktbW9kZS1yZXNvdXJjZXMvcnVieS5yYgorKysgYi90ZXN0L2xpc3Av cHJvZ21vZGVzL3J1YnktbW9kZS1yZXNvdXJjZXMvcnVieS5yYgpAQCAtNTM2LDMgKzUzNiw3 IEBAIGRlZiBmb289KAogICAgIGhlbGxvCiAgIGVuZAogZW5kCisKKyMgTG9jYWwgVmFyaWFi bGVzOgorIyBydWJ5LW1ldGhvZC1wYXJhbXMtaW5kZW50OiB0CisjIEVuZDoKZGlmZiAtLWdp dCBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXRlc3RzLmVsIGIvdGVzdC9saXNw L3Byb2dtb2Rlcy9ydWJ5LW1vZGUtdGVzdHMuZWwKaW5kZXggOWJlMDFkYzc4ZjkuLmFkOWZj M2RhZDRkIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS10ZXN0 cy5lbAorKysgYi90ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS10ZXN0cy5lbApAQCAt OTQzLDcgKzk0Myw3IEBAIHJ1YnktaW1lbnUtd2l0aC1wcml2YXRlLW1vZGlmaWVyCiAgICAg ICAgICAgICAgICAgICAgICAiQmx1YiNieWUiCiAgICAgICAgICAgICAgICAgICAgICAiQmx1 YiNoaWRpbmciKSkpKSkKIAotKGVydC1kZWZ0ZXN0IHJ1YnktLWluZGVudC9jb252ZXJ0ZWQt ZnJvbS1tYW51YWwtdGVzdCAoKQorKGVydC1kZWZ0ZXN0IHJ1YnktLWluZGVudC9ydW4tbWFu dWFsLXRlc3QgKCkKICAgOnRhZ3MgJyg6ZXhwZW5zaXZlLXRlc3QpCiAgIDs7IENvbnZlcnRl ZCBmcm9tIG1hbnVhbCB0ZXN0LgogICAobGV0ICgoYnVmIChmaW5kLWZpbGUtbm9zZWxlY3Qg KGVydC1yZXNvdXJjZS1maWxlICJydWJ5LnJiIikpKSkKQEAgLTk1NCw2ICs5NTQsMTcgQEAg cnVieS0taW5kZW50L2NvbnZlcnRlZC1mcm9tLW1hbnVhbC10ZXN0CiAgICAgICAgICAgICAo c2hvdWxkIChlcXVhbCAoYnVmZmVyLXN0cmluZykgb3JpZykpKSkKICAgICAgIChraWxsLWJ1 ZmZlciBidWYpKSkpCiAKKyhlcnQtZGVmdGVzdCBydWJ5LS1pbmRlbnQvcnVuLW1hbnVhbC10 ZXN0LW1ldGhvZC1wYXJhbXMtaW5kZW50ICgpCisgIDp0YWdzICcoOmV4cGVuc2l2ZS10ZXN0 KQorICA7OyBDb252ZXJ0ZWQgZnJvbSBtYW51YWwgdGVzdC4KKyAgKGxldCAoKGJ1ZiAoZmlu ZC1maWxlLW5vc2VsZWN0IChlcnQtcmVzb3VyY2UtZmlsZSAicnVieS1tZXRob2QtcGFyYW1z LWluZGVudC5yYiIpKSkpCisgICAgKHVud2luZC1wcm90ZWN0CisgICAgICAgICh3aXRoLWN1 cnJlbnQtYnVmZmVyIGJ1ZgorICAgICAgICAgIChsZXQgKChvcmlnIChidWZmZXItc3RyaW5n KSkpCisgICAgICAgICAgICAoaW5kZW50LXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4 KSkKKyAgICAgICAgICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5nKSBvcmlnKSkp KQorICAgICAgKGtpbGwtYnVmZmVyIGJ1ZikpKSkKKwogKGVydC1kZWZ0ZXN0IHJ1YnktLXRl c3QtY2hhaW5lZC1pbmRlbnRhdGlvbiAoKQogICAod2l0aC10ZW1wLWJ1ZmZlcgogICAgIChy dWJ5LW1vZGUpCg== --------------QBgd79avVZ2t0qLRyVhnrdv5--