From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#43464: 28.0.50; vc: Error calling vc-revert for repo root Date: Mon, 5 Oct 2020 13:19:19 +0300 Message-ID: References: <0b1c72d0-f8fb-a256-1563-1c43296c8edb@yandex.ru> <11761d79-1893-fdf3-843d-bea4a026fc7f@yandex.ru> <7b4d0bcf-c622-b2db-34d6-e587fe516f8d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28348"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 43464@debbugs.gnu.org To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 05 12:20:29 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPNbZ-0007EH-GH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Oct 2020 12:20:29 +0200 Original-Received: from localhost ([::1]:36760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPNbY-0000N1-IF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Oct 2020 06:20:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPNb8-0000Mi-MS for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 06:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPNb8-0005x7-CM for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 06:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPNb8-0003MG-7l for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 06:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Oct 2020 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 43464-submit@debbugs.gnu.org id=B43464.160189317012852 (code B ref 43464); Mon, 05 Oct 2020 10:20:02 +0000 Original-Received: (at 43464) by debbugs.gnu.org; 5 Oct 2020 10:19:30 +0000 Original-Received: from localhost ([127.0.0.1]:48006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPNac-0003LD-8D for submit@debbugs.gnu.org; Mon, 05 Oct 2020 06:19:30 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:40814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPNaa-0003Kw-IG for 43464@debbugs.gnu.org; Mon, 05 Oct 2020 06:19:29 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id p13so2728869edi.7 for <43464@debbugs.gnu.org>; Mon, 05 Oct 2020 03:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e7c+qpxmLPGYul7LbQkPPuwJvMweWj6SPE8yFmpPXyE=; b=Nxc4RAHYZD7t3hcu/7Ycl2Nz6ZO35JeGD+pg4RwDBuRtpR6WZbqaei6vhxW0JjuN1Q Upd1CymSiIllAPsNGuLdiiYQWO38o9tCidR3YJpvtFPUwB4INLcd0zqvSdzjA951wOZO ZZFbZ+BMVQ1EU373JBU8VXXwaWi9aFzy9Tp6Dzqzo/2JQtWn7qbW4QUDWNJy8FY84YMl /qc31n4Rbaj8bG6fgPC2dQYCDt1Ovy2vrGBpZ9cMGk6t4LwRrN9sI3uf6NWjKOP34zdu bW5B407mTb58WGvgDAB4ilPUrJ/16alDSOa3X7Aj/8Zln0lrlQt0+Rb14VYP+z1IznYI 98SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e7c+qpxmLPGYul7LbQkPPuwJvMweWj6SPE8yFmpPXyE=; b=jxlngYEYTg0CBKYcRggOYLg5rqjuwPtARwH/DrmJ6fGGSLFSlCd/0ksrmHoltzhfIH mMfIkJNSXXKbkp8qGhDgHTlROdoPsJXm55m+oPrUasdEOHVypg1bp3YzRWVZKDeE+OgV 43ULumn8fRzDEu0cYacv6l4XUyHURJAjxaYABudstLyj1fmDHUR6TY75DWlPi0Md6DVP LJi65wAh/bt9ClZBYCviKiyezPYV+pD1tUIVwGrnwnp2hkvq8JrvRpKY0Xy4v12C0vld xnl91J+eV1qjtVOOpW2NrCIVC/MGAj1pwP9c5YZ24GNriaPL4ucQqwlJLvm4xL9KA7h2 C9rw== X-Gm-Message-State: AOAM530PbuPUe3oITChPixQMZgjOSgv6Q+DCXksw7xL4IXmoy/wGQOht n5jDrxeFlqA3hx1dpmjAX/twNOfjBY1ccA== X-Google-Smtp-Source: ABdhPJx4puq7hHv5vLtAttBlPfUbm6Si7HdW/1HOeyQ55h5HjSKKRlJVMxZirZLc6ifsUoDAzjHZvg== X-Received: by 2002:a50:ab59:: with SMTP id t25mr15679701edc.364.1601893162408; Mon, 05 Oct 2020 03:19:22 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id n25sm2813277ejd.114.2020.10.05.03.19.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Oct 2020 03:19:20 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189818 Archived-At: On 05.10.2020 09:02, Andrii Kolomoiets wrote: > Dmitry Gutov writes: > >> Where is that vc-backend called from, in our scenario? > > It's called from 'vc-call'. The 'vc-revert-file' used it twice > to call the 'make-version-backups-p' and the 'revert' backend functions. Then a change in vc-revert-file could be sufficient. >> Could we make do with changing that code to use vc-responsible-backend >> instead of vc-backend instead? If it's not a function called >> frequently. > > I went a little different way and made the 'vc-backend' return correct > backend for directories. In case you missed it somehow here is the link > to the message: > > https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-09/msg02508.html Like I explained, it will create a cache entry that is never invalidated.