From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer Date: Mon, 22 Jun 2020 03:59:38 +0300 Message-ID: References: <87a70x8f7g.fsf@mail.linkov.net> <87wo40ghht.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="75863"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 Cc: 41974@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 22 03:00:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnAom-000JcP-Lh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Jun 2020 03:00:12 +0200 Original-Received: from localhost ([::1]:37176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnAol-0003Md-E4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 21:00:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnAoc-0003MH-TH for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 21:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnAoc-0004bC-JQ for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 21:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnAoc-0002tI-GE for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 21:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jun 2020 01:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41974 X-GNU-PR-Package: emacs Original-Received: via spool by 41974-submit@debbugs.gnu.org id=B41974.159278758911055 (code B ref 41974); Mon, 22 Jun 2020 01:00:02 +0000 Original-Received: (at 41974) by debbugs.gnu.org; 22 Jun 2020 00:59:49 +0000 Original-Received: from localhost ([127.0.0.1]:32938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnAoP-0002sF-HG for submit@debbugs.gnu.org; Sun, 21 Jun 2020 20:59:49 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:38235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnAoN-0002rx-5g for 41974@debbugs.gnu.org; Sun, 21 Jun 2020 20:59:47 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id f18so1572669wml.3 for <41974@debbugs.gnu.org>; Sun, 21 Jun 2020 17:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=K9gHk7uNBFMLbjNCriF0eyP14kTflPuCoo5P/qhP4G0=; b=J2IODVE7cIxQpMNXE9ijoYq4a0deZYl42Y2OaeITIG2IM2Vqml1yU2ZUtZZwpVgjRr oryDyKvJa6eM+SH+QEKz6hGISKgNs+IQdYIRqG/l0P7KBfXcPK67AmT4cuM8MZnTBPLs RtgMWjTx72znUYnMiEW7aXX/FiO3fjKia59nv5d3W7jOrY/8lnvHFroKIshphjY+vAcz wQbZM78tLaDQhhsBpBwaAzAt/EhQaS61u7f2pzKAgLz+i3XutF3KxbVADPCqhlvhVb9C SYViqtlH0r1vqxS5cpg3cQkftUnCm0Xr1B4ZqLiUFUAVo5Yz1DW9XQbZcwUvpk3QH4Pn TpaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K9gHk7uNBFMLbjNCriF0eyP14kTflPuCoo5P/qhP4G0=; b=MfvftR7R4rZkt71KpA/ZNJpmeJZvxJeLqL7KrVBlPkSjXo0vFD5diPYmgFxUvTkPM9 lAuVlnfqIIpRjOXclkGFs6/MlRRz8+gpmhPWquiP8LVB9RQHBZ12iIZhn9iQHI9KHKhg 3mX0bXaK5qbdUrO1GMxToy/oyO9/3J/9VmFM3vzFPIA9SVmDfrIMDvOlH4jna4OvQIms 74JAHwhgkHezNR0zx7ktZ4LazsL31yF6ITPEkLJDfVAiWO/2deiJN+rahYfr2Ui2v0oF r6SdoQI2eyhGZEmakzIpjdHKIbFZShj//b0hJB9IuL+bbdyYDcOp35HfuHqywP9+iLlS mEGw== X-Gm-Message-State: AOAM532QDlt4s2DcGNCvgpx2XQtxxHOeJqiftKFryod1E8zJJby/SSHp JbLK+sTOplHAaqIKu63Ei5Akt++c X-Google-Smtp-Source: ABdhPJys3FaAUJrZG1h3Oq3uCPlfeKGoEUu4E1OkfB/LD3wZxbnPabbY/7XY0sqUdPdgNe6TEAGBhg== X-Received: by 2002:a7b:cb4c:: with SMTP id v12mr15526749wmj.43.1592787581048; Sun, 21 Jun 2020 17:59:41 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id v20sm1957614wmh.26.2020.06.21.17.59.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jun 2020 17:59:40 -0700 (PDT) In-Reply-To: <87wo40ghht.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182269 Archived-At: On 22.06.2020 01:51, Juri Linkov wrote: > Strange, this patch has no effect, the same error remains. Sorry, that was a brain fart. How about this: diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 9b12d44978..6bb72d8976 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1074,11 +1074,11 @@ vc-deduce-fileset (progn ;FIXME: Why not `with-current-buffer'? --Stef. (set-buffer vc-parent-buffer) (vc-deduce-fileset not-state-changing allow-unregistered state-model-only-files))) - ((and (derived-mode-p 'log-view-mode) + ((and (not buffer-file-name) (setq backend (vc-responsible-backend default-directory))) (list backend nil)) ((not buffer-file-name) - (error "Buffer %s is not associated with a file" (buffer-name))) + (error "Buffer %s is not recognized by any VC backend" (buffer-name))) ((and allow-unregistered (not (vc-registered buffer-file-name))) (if state-model-only-files (list (vc-backend-for-registration (buffer-file-name))