From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Wed, 14 Apr 2021 02:54:06 +0300 Message-ID: References: <87pmz8lc17.fsf@mail.linkov.net> <9453a08f-5014-b4bc-8472-a4c2ff44c687@yandex.ru> <87o8eo38q9.fsf@mail.linkov.net> <7f1b570f-ea1b-5524-59fa-83bb5eaa9abd@yandex.ru> <87eefh9176.fsf@mail.linkov.net> <5c7b677f-0f4a-bbef-8c1f-42cd024c7314@yandex.ru> <87czuzxysf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22078"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: 47566-done@debbugs.gnu.org, Ramesh Nedunchezian To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 14 01:55:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWSsB-0005dE-SR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 01:55:11 +0200 Original-Received: from localhost ([::1]:38692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWSsA-0002Wr-Ge for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Apr 2021 19:55:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWSs2-0002WW-E4 for bug-gnu-emacs@gnu.org; Tue, 13 Apr 2021 19:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWSs2-0004zk-6h for bug-gnu-emacs@gnu.org; Tue, 13 Apr 2021 19:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWSs2-0001Sv-4w for bug-gnu-emacs@gnu.org; Tue, 13 Apr 2021 19:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Apr 2021 23:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47566 X-GNU-PR-Package: emacs Original-Received: via spool by 47566-done@debbugs.gnu.org id=D47566.16183580565569 (code D ref 47566); Tue, 13 Apr 2021 23:55:02 +0000 Original-Received: (at 47566-done) by debbugs.gnu.org; 13 Apr 2021 23:54:16 +0000 Original-Received: from localhost ([127.0.0.1]:32980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWSrI-0001Rl-KP for submit@debbugs.gnu.org; Tue, 13 Apr 2021 19:54:16 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:46932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWSrH-0001RY-RV for 47566-done@debbugs.gnu.org; Tue, 13 Apr 2021 19:54:16 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id c15so9129167wro.13 for <47566-done@debbugs.gnu.org>; Tue, 13 Apr 2021 16:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/mPsu9ae8qQsISxGoMMLZl/8S6VSOyYQ8ykoQ2M0rIA=; b=izjKUpKLtlde5Nx9dt2WxrtaXWUZz7BQ+oN9bwAzHSLQqjj4S5xnLOtQCjVmt3y5ZN A5VPEa+VnpEPhXuTn1aD7NacfhdVXHNKejyMMBI2CWv0w0FymJkMTHVC6WvqSi4gNJU+ DaWmPeJQKUCMAXWeBLzDB3idmmwTDAMN7y5Yko2ASLEGYqasQI8PJEBM2/84W/AwAnC0 AU/aS+wjhUKEF8PWEgBERlJYPIHmxZAnuxbvRUxTfZtpff/a35vNWM56nEq//sH7zcXp dUQK7VcPAeOf3n/aEaOT6c5YmzeVB5l1bqTrNSnmmdUD7Hm1W7r5v7kBNk6qlZX2/oAf iGcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/mPsu9ae8qQsISxGoMMLZl/8S6VSOyYQ8ykoQ2M0rIA=; b=YBr5hP7WArRsW4+hpyZr8M+eakRNdXdkHMZDbbSRdYrZ6dkjiPkOMr1a+E0kM78yu4 HPm2mKVeoZJMSFI8T64oBM4IlTPB/vM6Ai7feCT+UGvvVOmYOtV10LedVlJ8ewdv0lhv gwsTizHstrhSuxCivrQPbMiOmNaa4bDd/v2RzkQ8Ex8+RpIdiEkpKzzXXYLR/1RCt1Jz hzBPzTABbrH7lijjMvhx4BoHP7YDIiuQ5ORv3NYt2Gs7LkP1Y04MMKmPk1vbiOd+yyCD 2TmC+OWJ0wsfuo3sagJC3bu4oKqo/FYLstewV7TG8xttfyKNJxDvDbe2/E2erFZguq43 vIJA== X-Gm-Message-State: AOAM531guigyvEb5yqONbq82vML9cZ+42UcOV4qx0Ig5aH/cwxGuluYz XnvlAbgq0waIHqH8UWrwCUM= X-Google-Smtp-Source: ABdhPJylObzSaWeTTTPYJeQ5l1Th7EWQc58frKUuuvSjB+F0ufmxPmXMsJmchkMZ2VznyDUDwXSZiQ== X-Received: by 2002:adf:f04d:: with SMTP id t13mr14872513wro.52.1618358049905; Tue, 13 Apr 2021 16:54:09 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v189sm4434206wmg.9.2021.04.13.16.54.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 16:54:08 -0700 (PDT) In-Reply-To: <87czuzxysf.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203993 Archived-At: On 12.04.2021 19:17, Juri Linkov wrote: >>> I can't find the face named 'deemphasized'. >> >> Sorry. >> >> Apparently, it's a face that only the tango-plus theme defines (unwisely). >> >> It simply looks like less contrasting text. Try 'shadow' instead, it's >> about the same. > > I'm not sure about deemphasizing by default. But now it's easy to > customize this, and add any emphazing. Thanks. Consider adding a repeat-mode-echo option which follows what Smartrep does: instead of adding to the echo area, it just highlights the changed state in the mode line (basically a long mode lighter saying "========SMARTREP=======") and also colors the mode-line green. IME that works well as an indicator that we're in a "special" state. Though perhaps we could use a smaller text (like "[REPEAT]") and only color the text inside the brackets, rather than the whole mode-line. Could use some experimentation.