unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
	Mauro Aranda <maurooaranda@gmail.com>
Cc: 41145@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>
Subject: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group
Date: Sun, 30 Aug 2020 08:09:21 -0700 (PDT)	[thread overview]
Message-ID: <b5dd4bdf-2caa-4a3a-982f-d6c9e99c75b6@default> (raw)
In-Reply-To: <jwv36441993.fsf-monnier+emacs@gnu.org>

FWIW, I've said it before, and reiterate now: I
think :group should always be explicitly present.

We've gone to the other extreme, of not only
encouraging its removal (apart from an initial
occurrence), but even removing it from patches
that contained it.

Why do I feel this way?  Repeating what I've
said before:

1. Nothing is really gained.  The amount of
   additional text eliminated is trivial - tiny.

2. A defcustom that's not near a previous one
   has its :group unclear (for humans).

3. It's problematic and error prone wrt moving
   defcustoms around.

It doesn't hurt, and it can help human readers
to just include explicit :group.

Whether that should just be conventional (i.e.,
recommended/encouraged) or actually enforced is
a different question.  I'm not sure it needs to
be enforced (e.g. warning or error msg), but I
don't think that would hurt, and it might help.

Just one opinion.  I repeat it here only because
I haven't mentioned it in a long time - probably
not since the crusade to remove "unnecessary"
:groups was initiated.

(And no, this is not very important.  Just sayin.)





  parent reply	other threads:[~2020-08-30 15:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  8:30 bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Philipp Stephani
2020-05-09  9:37 ` Eli Zaretskii
2020-05-09 12:31   ` Philipp Stephani
2020-08-28 14:48 ` Mauro Aranda
2020-08-29  6:54   ` Eli Zaretskii
2020-08-29 15:36     ` Stefan Monnier
2020-08-29 16:23       ` Mauro Aranda
2020-08-30  3:58         ` Stefan Monnier
2020-08-30 11:52           ` Mauro Aranda
2020-08-30 14:51             ` Stefan Monnier
2020-08-30 15:09               ` Eli Zaretskii
2020-08-30 17:03                 ` Stefan Monnier
2020-09-04  2:24                   ` Stefan Monnier
2020-09-04  7:09                     ` Eli Zaretskii
2020-09-04 12:47                       ` Stefan Monnier
2020-08-30 15:09               ` Drew Adams [this message]
2020-09-11 23:26               ` Michael Heerdegen
2020-09-12 15:43                 ` Stefan Monnier
2020-09-12 18:51                   ` Michael Heerdegen
2020-08-30 13:50           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5dd4bdf-2caa-4a3a-982f-d6c9e99c75b6@default \
    --to=drew.adams@oracle.com \
    --cc=41145@debbugs.gnu.org \
    --cc=maurooaranda@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).