From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#19170: 25.0.50; enhancement request: `compare-windows' use across frames Date: Fri, 28 Nov 2014 14:20:07 -0800 (PST) Message-ID: References: <32848088-e8db-46dc-b9c7-f53bc46bb4e1@default> <87egss9r7v.fsf@mail.linkov.net> <2f6cb7a6-e050-4909-9b54-d651523bb5d5@default> <87egss86a8.fsf@mail.linkov.net> <87egsr0xjt.fsf@mail.linkov.net> <87egsqzy74.fsf@mail.linkov.net> <877fyhfno0.fsf@mail.linkov.net> <3dcedc6e-0613-4af5-a061-02395bc9a506@default> <87y4qw5elz.fsf@mail.linkov.net> <54782455.3020206@gmx.at> <8761dzxc05.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1417213291 1386 80.91.229.3 (28 Nov 2014 22:21:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Nov 2014 22:21:31 +0000 (UTC) Cc: 19170@debbugs.gnu.org To: Juri Linkov , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 28 23:21:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XuTum-0000Ja-5f for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Nov 2014 23:21:24 +0100 Original-Received: from localhost ([::1]:46200 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuTul-0007Nw-CI for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Nov 2014 17:21:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuTuZ-0007Nr-Kz for bug-gnu-emacs@gnu.org; Fri, 28 Nov 2014 17:21:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuTuQ-0004y9-Uq for bug-gnu-emacs@gnu.org; Fri, 28 Nov 2014 17:21:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuTuQ-0004y3-Rk for bug-gnu-emacs@gnu.org; Fri, 28 Nov 2014 17:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XuTuQ-0007WC-L5 for bug-gnu-emacs@gnu.org; Fri, 28 Nov 2014 17:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Nov 2014 22:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19170 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19170-submit@debbugs.gnu.org id=B19170.141721322128824 (code B ref 19170); Fri, 28 Nov 2014 22:21:02 +0000 Original-Received: (at 19170) by debbugs.gnu.org; 28 Nov 2014 22:20:21 +0000 Original-Received: from localhost ([127.0.0.1]:48711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XuTtk-0007Uo-8c for submit@debbugs.gnu.org; Fri, 28 Nov 2014 17:20:20 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:17222) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XuTth-0007Ug-EC for 19170@debbugs.gnu.org; Fri, 28 Nov 2014 17:20:17 -0500 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sASMKEFg019352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Nov 2014 22:20:15 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id sASMKAST008416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 28 Nov 2014 22:20:12 GMT Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sASMKA2r012388; Fri, 28 Nov 2014 22:20:10 GMT In-Reply-To: <8761dzxc05.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96714 Archived-At: > Thank you, Martin. This is exactly what we need. Looks good to me. Please apply it. But "matching points" should be "match positions" - "point" can be confusing. Possible enhancements, but not required to close this enhancement request: 1. I do still think it would be good to provide more info in the message. 2. As I proposed in the past, I think it would be good to (as I do) bind comparison commands to the same prefix. I bind them to prefix `C-=3D' (just one possibility): C-=3D b is ediff-buffers C-=3D d is diff C-=3D e is ediff-files C-=3D f is ediff-files C-=3D w is compare-windows-repeat 3. `compare-windows-repeat' is just a repeatable version of `compare-windows', so you can repeat it using, for example, `C-=3D w w w w w'. Very handy, especially given the improvements you've just made. Maybe consider doing #3 even if you don't want to do #2. I use the definition below, but you can do it another way (e.g., using `set-transient-map'). I use this helper function all the time. It makes it trivial to make a repeatable command: (defun repeat-command (command) "Repeat COMMAND." (let ((repeat-message-function 'ignore)) (setq last-repeatable-command command) (repeat nil))) So for example: (defun compare-windows-repeat (ignore-whitespace) "Compare text in current window with text in next window. You can repeat this by hitting the last key again... See `compare-windows' - this is the same, except repeatable." (interactive "P") (require 'repeat) (repeat-command 'compare-windows))