unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>,
	Lars Ingebrigtsen <larsi@gnus.org>,
	29405@debbugs.gnu.org
Subject: bug#29405: 27.0.50; message-faces: Doc fixes and syntax touch-ups
Date: Fri, 01 Dec 2017 18:56:54 +0900	[thread overview]
Message-ID: <b4mvahqg49l.fsf@jpl.org> (raw)
In-Reply-To: <87zi7ef3ab.fsf@gmail.com>

On Fri, 01 Dec 2017 10:51:06 +0200, Eli Zaretskii wrote:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Wed, 22 Nov 2017 20:48:28 +0000

>> I attach three patches pertaining to the faces defined in
>> lisp/gnus/message.el in descending order of importance:

>> 1. Fix docstring mistakes and inconsistencies.

>> 2. Use define-obsolete-face-alias instead of duplicating it.

>> 3. Use the newer (DISPLAY . PLIST) face spec syntax,
>>    as per `(elisp) Defining Faces'.

> Lars, Yamaoka-san -- any comments on these?

> I've installed the first one on the emacs-26 branch, as it's clearly a
> bugfix in doc strings.  But I would like to hear your opinions on the
> rest.

I think all are very good fixes.
`3.' makes XEmacs malfunction AFAIK, but of course it's OK.

Thanks.





  reply	other threads:[~2017-12-01  9:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 20:48 bug#29405: 27.0.50; message-faces: Doc fixes and syntax touch-ups Basil L. Contovounesios
     [not found] ` <handler.29405.B.15113837311413.ack@debbugs.gnu.org>
2017-11-22 20:56   ` Basil L. Contovounesios
2017-12-01  8:51 ` Eli Zaretskii
2017-12-01  9:56   ` Katsumi Yamaoka [this message]
2017-12-01 11:07   ` Lars Ingebrigtsen
2017-12-02  9:17     ` Eli Zaretskii
2017-12-13  1:04       ` Basil L. Contovounesios
2017-12-13  1:19         ` Basil L. Contovounesios
2017-12-15 10:22           ` Eli Zaretskii
2017-12-15 10:22         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mvahqg49l.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=29405@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).