unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Nicolas Richard <theonewiththeevillook@yahoo.fr>, 18257@debbugs.gnu.org
Subject: bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode.
Date: Thu, 26 Jan 2017 17:55:50 +0900	[thread overview]
Message-ID: <b4mr33qqjxl.fsf@jpl.org> (raw)
In-Reply-To: <87tx5gfyx5.fsf@yahoo.fr>

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

On Thu, 26 Jan 2017 17:10:51 +0900, Katsumi Yamaoka wrote:
> Sorry, that is my fault.  How about this patch?

I'm sorry again.  This is the right one:

* lisp/gnus/gnus-art.el (gnus-article-describe-bindings):
Ignore summary commands that aren't bound to
gnus-article-read-summary-keys keys (bug#18257).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 995 bytes --]

--- gnus-art.el~	2017-01-25 22:07:29.825734200 +0000
+++ gnus-art.el	2017-01-26 08:54:39.004906700 +0000
@@ -6846,17 +6846,21 @@
   (let ((keymap (copy-keymap gnus-article-mode-map))
 	(map (copy-keymap gnus-article-send-map))
 	(sumkeys (where-is-internal 'gnus-article-read-summary-keys))
+	(summap (make-sparse-keymap))
 	parent agent draft)
     (define-key keymap "S" map)
     (define-key map [t] nil)
+    (define-key summap [t] 'undefined)
     (with-current-buffer gnus-article-current-summary
+      (dolist (key sumkeys)
+	(define-key summap key (key-binding key (current-local-map))))
       (set-keymap-parent
        keymap
        (if (setq parent (keymap-parent gnus-article-mode-map))
 	   (prog1
 	       (setq parent (copy-keymap parent))
-	     (set-keymap-parent parent (current-local-map)))
-	 (current-local-map)))
+	     (set-keymap-parent parent summap))
+	 summap))
       (set-keymap-parent map (key-binding "S"))
       (let (key def gnus-pick-mode)
 	(while sumkeys

  reply	other threads:[~2017-01-26  8:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87tx5gfyx5.fsf@yahoo.fr>
     [not found] ` <87fuk7lygr.fsf@gnus.org>
2017-01-25 21:55   ` bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode Lars Ingebrigtsen
2017-01-26  8:10     ` Katsumi Yamaoka
2017-01-26  8:55       ` Katsumi Yamaoka [this message]
2017-01-26 17:12         ` Lars Ingebrigtsen
2017-01-26 22:44           ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mr33qqjxl.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=18257@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=theonewiththeevillook@yahoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).