From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: Re: gnus-summary-catchup turns ticked into unread Date: Tue, 03 Jul 2007 19:25:37 +0900 Organization: Emacsen advocacy group Message-ID: References: <20070702160929.C21251C8115@galatea.esat.kuleuven.be> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1183464769 24360 80.91.229.12 (3 Jul 2007 12:12:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 3 Jul 2007 12:12:49 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, bugs@gnus.org To: Luc Van Eycken Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 03 14:12:46 2007 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I5hFL-0000TS-Af for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jul 2007 14:12:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I5hFK-0006Bx-OS for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jul 2007 08:12:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I5fZy-0000AA-Pk for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2007 06:25:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I5fZx-000062-Eo for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2007 06:25:54 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I5fZw-00005d-45 for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2007 06:25:52 -0400 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I5fZu-0004vG-St for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2007 06:25:51 -0400 Original-Received: from [66.225.201.151] (port=39269 helo=mail.jpl.org) by orlando.hostforweb.net with esmtpa (Exim 4.63) (envelope-from ) id 1I5fZq-00006C-FR; Tue, 03 Jul 2007 05:25:47 -0500 X-Hashcash: 1:20:070703:luc.vaneycken@esat.kuleuven.be::C8Gt0KUplriel44j:00000000000000000000000000000004VsA X-Hashcash: 1:20:070703:bug-gnu-emacs@gnu.org::DVwRzezxrQ2v4kkn:00000000000000000000000000000000000000007AQ1 X-Hashcash: 1:20:070703:bugs@gnus.org::/gTvRWkryahR8JR9:00000Lq/ X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) Cancel-Lock: sha1:VIh0Vq5aOfO4jVxbwOAjH4ossQg= X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-kernel: Genre and OS details not recognized. X-Mailman-Approved-At: Tue, 03 Jul 2007 08:12:07 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16065 Archived-At: --=-=-= >>>>> In <20070702160929.C21251C8115@galatea.esat.kuleuven.be> >>>>> Luc Van Eycken wrote: > If I have a newsgroup with ticked persistent articles and I leave this > group with the "c" key (gnus-summary-catchup-and-exit), all ticked articles > are turned into unread non-ticked articles. It is a regression from Emacs 21, > but I also believe this is a bug since it seems to contradict the info > documentation. That's a coincidence! When I was wandering in the Agent code today, I encountered the same trouble and reached to the same place in gnus-sum.el. > As far as I can see, it is due to the addition of gnus-newsgroup-unfetched > inside the function gnus-summary-catchup (gnus-sum.el line 10517). > Since this is a Gnus 5.11 addition, I assume that removing it again is not > the correct solution. I think regarding unfetched articles as unread articles is correct. The problem is that cached articles are not counted as fetched articles, or Gnus forgot that those cached articles used to have been fetched. I'm not quite sure how it happens because I'm new to the Agent. But I briefly checked that the patch attached below does the trick. --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- gnus-sum.el~ 2007-06-06 15:39:11 +0000 +++ gnus-sum.el 2007-07-03 10:22:57 +0000 @@ -10514,7 +10514,8 @@ (gnus-sorted-nunion (gnus-sorted-intersection gnus-newsgroup-unreads gnus-newsgroup-downloadable) - gnus-newsgroup-unfetched))) + (gnus-sorted-difference gnus-newsgroup-unfetched + gnus-newsgroup-cached)))) ;; We actually mark all articles as canceled, which we ;; have to do when using auto-expiry or adaptive scoring. (gnus-summary-show-all-threads) --=-=-= Content-Disposition: inline I am going to install it (or other) in the Gnus CVS repository after learning the Agent further. Regards, --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ bug-gnu-emacs mailing list bug-gnu-emacs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs --=-=-=--