From: Katsumi Yamaoka <yamaoka@jpl.org>
To: larsi@gnus.org
Cc: 23964@debbugs.gnu.org
Subject: bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers
Date: Fri, 22 Jul 2016 20:08:42 +0900 [thread overview]
Message-ID: <b4mk2gegcat.fsf@jpl.org> (raw)
In-Reply-To: <m3k2gqxc5y.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Thu, 21 Jul 2016 17:46:18 +0900, Katsumi Yamaoka wrote:
> I realized `+' works for some html mails but doesn't for others.
I'm not quite sure this is the right approach, but I seem to have
found the cause and the solution. `shr-image-fetched', that
`shr-tag-img' calls, overrides the keymap text property on an
image with the value that was there before inserting the image,
that is, nil. Could you please test this patch?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 405 bytes --]
--- shr.el~ 2016-07-21 08:35:17.668496000 +0000
+++ shr.el 2016-07-22 11:05:56.349491100 +0000
@@ -937,7 +937,7 @@
(while properties
(let ((type (pop properties))
(value (pop properties)))
- (unless (memq type '(display image-size))
+ (unless (memq type '(display image-size keymap))
(put-text-property start (point) type value))))))))))
(kill-buffer image-buffer)))
next prev parent reply other threads:[~2016-07-22 11:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 6:52 bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers Lars Ingebrigtsen
2016-07-14 2:09 ` Katsumi Yamaoka
2016-07-20 12:47 ` Lars Ingebrigtsen
2016-07-21 8:46 ` Katsumi Yamaoka
2016-07-22 11:08 ` Katsumi Yamaoka [this message]
2016-07-22 11:11 ` Lars Ingebrigtsen
2016-07-24 8:27 ` Lars Ingebrigtsen
2016-07-24 22:53 ` Katsumi Yamaoka
2016-07-25 18:44 ` Lars Ingebrigtsen
2016-07-25 23:50 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mk2gegcat.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=23964@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).