From: Katsumi Yamaoka <yamaoka@jpl.org>
To: 24422@debbugs.gnu.org
Cc: tsuchiya@namazu.org
Subject: bug#24422: Proposal to create `sieve-manage-ignore-broken-tls' option
Date: Wed, 14 Sep 2016 09:08:17 +0900 [thread overview]
Message-ID: <b4mintzl4we.fsf@jpl.org> (raw)
In-Reply-To: <87k2egsxgb.fsf@tsuchiya.vaj.namazu.org>
On Tue, 13 Sep 2016 09:21:48 -0400, Ted Zlatanov wrote:
> On Tue, 13 Sep 2016 08:08:37 +0900 Katsumi Yamaoka <yamaoka@jpl.org> wrote:
KY> On Mon, 12 Sep 2016 15:57:24 -0400, TSUCHIYA Masatoshi wrote:
>>> When accessing a managesieve server which provides broken TLS
>>> connections, it is quite useful that sieve-manage-open-server() ignores
>>> STARTTLS capability. Therefore, I propose the following patch.
KY> The patch looks fine and not likely to cause a trouble. I've
KY> committed it in the Emacs master with this log entry:
KY> sieve-manage.el: Allow user to avoid STARTTLS capability test (bug#24422)
KY> * lisp/net/sieve-manage.el
KY> (sieve-manage-ignore-broken-tls): New user option.
KY> (sieve-manage-open-server):
KY> Don't test STARTTLS capability if the option is set (bug#24422).
> I think the option is badly named. It doesn't ignore broken TLS
> (whatever that means), it avoids STARTTLS altogether. So maybe it should
> be `sieve-manage-ignore-starttls' or something like that.
Agreed. I misunderstood what it tries to do. It is irrelevant
if the one is broken or not, it simply makes it not use STARTTLS,
and the docstring is correct:
"Ignore STARTTLS even if STARTTLS capability is provided."
I've renamed it as suggested, with this log entry:
sieve-manage.el: Rename sieve-manage-ignore-broken-tls
* lisp/net/sieve-manage.el (sieve-manage-ignore-starttls):
Rename from sieve-manage-ignore-broken-tls. If it is set,
sieve-manage will never use STARTTLS even if the server says
it is capable (but may be broken).
Thanks.
next prev parent reply other threads:[~2016-09-14 0:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 19:57 bug#24422: Proposal to create `sieve-manage-ignore-broken-tls' option TSUCHIYA Masatoshi
2016-09-12 23:08 ` Katsumi Yamaoka
2016-09-13 13:21 ` Ted Zlatanov
2016-09-14 0:08 ` Katsumi Yamaoka [this message]
2016-09-20 13:00 ` Ted Zlatanov
2016-09-20 23:40 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mintzl4we.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=24422@debbugs.gnu.org \
--cc=tsuchiya@namazu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).