bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

[Vitalie Spinu]

I have noticed this issue for second time this week.

When trying to access emacs help (C-h f) I am getting the error:

    help-setup-xref: Symbol's value as variable is void: help-xref-following

I tracked it down to the warnign in *messages*

   Warning: defvar ignored because help-xref-following is let-bound


so the variable help-xref-following in help-mode.el is not getting
defined during the auto-load for the above reason.

Any ideas of how to debug this issue? It is not reproducible, it just
happens from time to time.

    Vitalie






In GNU Emacs 24.3.2 (i686-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2013-04-29 on vitoshka-home
Windowing system distributor `The X.Org Foundation', version 11.0.11303000
System Description:	Ubuntu 13.04

Configured using:
 `configure '--with-x-toolkit=lucid''

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

[Dmitry Gutov]

Vitalie Spinu <spinuvit@gmail.com> writes:

> I have noticed this issue for second time this week.
>
> When trying to access emacs help (C-h f) I am getting the error:
>
>     help-setup-xref: Symbol's value as variable is void: help-xref-following
>
> I tracked it down to the warnign in *messages*
>
>    Warning: defvar ignored because help-xref-following is let-bound
>
>
> so the variable help-xref-following in help-mode.el is not getting
> defined during the auto-load for the above reason.
>
> Any ideas of how to debug this issue? It is not reproducible, it just
> happens from time to time.

Looks like a problem with a third-party package. Someone let-binds
`help-xref-following' somewhere.

Here's an old commit in auto-complete fixing that:

https://github.com/auto-complete/auto-complete/commit/75482c79c5d1a46f9097cc27b568aa66ef0add07

bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

[Leo Liu]

On 2013-05-07 07:41 +0800, Dmitry Gutov wrote:
> Looks like a problem with a third-party package. Someone let-binds
> `help-xref-following' somewhere.
>
> Here's an old commit in auto-complete fixing that:
>
> https://github.com/auto-complete/auto-complete/commit/75482c79c5d1a46f9097cc27b568aa66ef0add07

Would be nice to know where it is let-bound. For example, octave.el (in
emacs trunk) does this but I cannot reproduce this bug with it.

Leo

bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

[Glenn Morris]

Leo Liu wrote:

> Would be nice to know where it is let-bound.

Use grep. AFAICS, nothing distributed with Emacs can cause this.
The only possible candidate in 24.3 is gnus-art, and I think that usage
is fine (see my other message).

> For example, octave.el (in emacs trunk) does this but I cannot
> reproduce this bug with it.

I think you are saved by with-help-window using
with-output-to-temp-buffer, which runs help-mode-setup via
temp-buffer-setup-hook.

bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

[Leo Liu]

On 2013-05-07 14:41 +0800, Glenn Morris wrote:
> I think you are saved by with-help-window using
> with-output-to-temp-buffer, which runs help-mode-setup via
> temp-buffer-setup-hook.

Thanks for that.

Leo

bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

[Katsumi Yamaoka]

Dmitry Gutov wrote:
> Looks like a problem with a third-party package. Someone let-binds
> `help-xref-following' somewhere.

> Here's an old commit in auto-complete fixing that:

> https://github.com/auto-complete/auto-complete/commit/75482c79c5d1a46f9097cc27b568aa66ef0add07

Sorry, I am at least one of the culprits.  I've committed a fix
to gnus-art.el in the trunk.  Please reopen this bug thread if
it doesn't solve the problem.

bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

[Glenn Morris]

Katsumi Yamaoka wrote:

> Sorry, I am at least one of the culprits. 

I don't think you are, since your help-xref-following binding comes
after a describe-bindings call, and that causes help-mode to be loaded.
But nevertheless your change is a good one for the sake of clarity.

I don't see anything in Emacs 24.3 that could cause this, so probably
some external package.

bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

[Vitalie Spinu]

 >> Glenn Morris <rgm@gnu.org>
 >> on Tue, 07 May 2013 02:40:38 -0400 wrote:

 > Katsumi Yamaoka wrote:
 >> Sorry, I am at least one of the culprits. 

 > I don't think you are, since your help-xref-following binding comes
 > after a describe-bindings call, and that causes help-mode to be loaded.
 > But nevertheless your change is a good one for the sake of clarity.

 > I don't see anything in Emacs 24.3 that could cause this, so probably
 > some external package.

I have grepped all the packages I am using and except gnus-art.el only
smartparents do in a functionality that I have never used.

I clean started gnus and invoked describe-bindings, and indeed it was
not causing this problem. But when invoked through helm-descbinds-mode
it did.

Here is how to reproduce:

   Enter gnus article and press C-h b (helm-descbinds), then C-g to
   exit, the let-binding warning appears and help-xref-following is not
   bound.

After updating gnus everything is fine.

Thanks, 
    Vitalie
    

bug#14356: 24.3; Symbol's value as variable is void: help-xref-following

[Katsumi Yamaoka]

Vitalie Spinu wrote:
[...]
> I clean started gnus and invoked describe-bindings, and indeed it was
> not causing this problem. But when invoked through helm-descbinds-mode
> it did.

> Here is how to reproduce:

>    Enter gnus article and press C-h b (helm-descbinds), then C-g to
>    exit, the let-binding warning appears and help-xref-following is not
>    bound.

> After updating gnus everything is fine.

Thanks for the confirmation.