From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#27084: 26.0.50; gnus-summary-toggle-header can fail to hide headers Date: Thu, 20 Jul 2017 16:17:10 +0900 Organization: Emacsen advocacy group Message-ID: References: <87poevpyqm.fsf@rosalinde> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1500535096 19135 195.159.176.226 (20 Jul 2017 07:18:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 20 Jul 2017 07:18:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (i686-pc-cygwin) Cc: 27084@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 20 09:18:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dY5it-0004hV-23 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Jul 2017 09:18:11 +0200 Original-Received: from localhost ([::1]:36392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dY5iy-00057d-Eb for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Jul 2017 03:18:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dY5iq-00057P-8t for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2017 03:18:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dY5ik-0000Ca-Fm for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2017 03:18:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45797) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dY5ik-0000CW-Ch for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2017 03:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dY5ik-0005yU-4D for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2017 03:18:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87poevpyqm.fsf@rosalinde> Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jul 2017 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27084 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27084-submit@debbugs.gnu.org id=B27084.150053504122899 (code B ref 27084); Thu, 20 Jul 2017 07:18:02 +0000 Original-Received: (at 27084) by debbugs.gnu.org; 20 Jul 2017 07:17:21 +0000 Original-Received: from localhost ([127.0.0.1]:48470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dY5i5-0005xH-46 for submit@debbugs.gnu.org; Thu, 20 Jul 2017 03:17:21 -0400 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:57388 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dY5i3-0005x3-N5 for 27084@debbugs.gnu.org; Thu, 20 Jul 2017 03:17:19 -0400 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from ) id 1dY5hv-003Tbp-EM; Thu, 20 Jul 2017 02:17:12 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:i2XMYUkQzyXpGd+BZQ9xSPXCBa4= X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134782 Archived-At: On Fri, 26 May 2017 14:51:45 +0200, Stephen Berman wrote: > The command `gnus-summary-toggle-header' correctly shows all headers of > an article in an Emacs bug report ephemeral group, but incorrectly fails > to rehide the headers that are hidden by default. To reproduce: Oops. Sorry. That's my fault: 2004-10-01 Katsumi Yamaoka * gnus-sum.el (gnus-summary-toggle-header): Make it work even if there's no visible header. --- ngnus-0.2/lisp/gnus-sum.el 2004-04-25 18:01:33.000000000 +0000 +++ ngnus-0.3/lisp/gnus-sum.el 2005-03-03 18:00:15.000000000 +0000 @@ -8810,7 +8911,8 @@ (inhibit-point-motion-hooks t) (hidden (if (numberp arg) (>= arg 0) - (gnus-article-hidden-text-p 'headers))) + (or (not (looking-at "[^ \t\n]+:")) + (gnus-article-hidden-text-p 'headers)))) s e) (delete-region (point-min) (point-max)) (with-current-buffer gnus-original-article-buffer An article that the change intended so as to make `gnus-summary-toggle-header' work for was the one in which there is no visible header that `gnus-visible-headers' specifies, like this: Delivered-To: foo Received: from... Received: from... MIME-Version: 1.0 That is, it's broken, there is no From, To, Cc, etc. as usual. Anyway I've fixed it by replacing (not (looking-at "[^ \t\n]+:")) with (looking-at "\n?\\'") + a comment. Regards,