unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: 11514-done@debbugs.gnu.org
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>,
	Romain Francoise <romain@orebokech.com>,
	Sven Joachim <svenjoac@gmx.de>
Subject: bug#11514: 24.0.97; gnus-user-agent no longer sets up Gcc
Date: Tue, 22 May 2012 08:29:09 +0900	[thread overview]
Message-ID: <b4md35xru4a.fsf@jpl.org> (raw)
In-Reply-To: <87bollw5d3.fsf@silenus.orebokech.com>

Sven Joachim wrote:
> On 2012-05-18 23:23 +0200, Romain Francoise wrote:

>> If you put the following in /tmp/foo.el:
>>
>> (setq mail-user-agent 'gnus-user-agent
>>       gnus-message-archive-group "nnimap+foo:Sent")
>>
>> then start Emacs with `emacs -Q -l /tmp/foo.el' then do `C-x m', the
>> resulting Message buffer doesn't have a Gcc header. In Emacs 23 and
>> 24.0.92, the Gcc header was (correctly, I think) added to the buffer.
>>
>> Note: whether or not Gnus is started beforehand doesn't make a difference.

This is the issue of only a case where Gnus is running, since
Gcc is Gnus' feature and the `gnus-user-agent' agent behaves
like the `message-user-agent' agent now if Gnus is not alive:

2012-02-09  Lars Ingebrigtsen  <larsi@gnus.org>

	* gnus-msg.el (gnus-msg-mail): Use `message-mail' if Gnus isn't
	running.

(So, why one uses `C-x m' rather than `m'?  Ok, he mey be in a
non-Gnus window.)

> This seems to have been introduced by the following change in the
> emacs-24 branch:

> ,----
>| revno: 107813
>| author: Lars Magne Ingebrigtsen <larsi@gnus.org>
>| committer: Katsumi Yamaoka <yamaoka@jpl.org>
>| branch nick: emacs-24
>| timestamp: Wed 2012-04-11 22:31:16 +0000
>| message:
>|   gnus-art.el (article-wash-html): Fix non-ASCII characters when
>| washing HTML (bug#7410).
>|   gnus-msg.el (gnus-inews-insert-gcc): Protect against when we don't
>| have a group name.
>|   gnus-start.el (gnus-read-newsrc-el-file): Protect against broken
>| .newsrc.el files.
> `----

> The diff for gnus-msg.el is this:

> === modified file 'lisp/gnus/gnus-msg.el'
> --- lisp/gnus/gnus-msg.el	2012-03-14 22:15:04 +0000
> +++ lisp/gnus/gnus-msg.el	2012-04-11 22:31:16 +0000
> @@ -1670,11 +1670,13 @@ this is a reply."
>  			(not
>  			 (setq result
>  			       (cond
> -				((stringp (caar var))
> +				((and group
> +				      (stringp (caar var)))
>  				 ;; Regexp.
>  				 (when (string-match (caar var) group)
>  				   (cdar var)))
> -				((functionp (car var))
> +				((and group
> +				      (functionp (car var)))
>  				 ;; Function.
>  				 (funcall (car var) group))
>  				(t

> It corresponds to commit bf5aff3ff7c87 in the no-gnus branch in Gnus
> git.

Reverting this change does not help.  I believe the right fix is
to modify `gnus-msg-mail' so as to bind `gnus-newsgroup-name' to
a string like `gnus-group-mail' does.  Fixed in the emacs-24 branch.





  reply	other threads:[~2012-05-21 23:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 21:23 bug#11514: 24.0.97; gnus-user-agent no longer sets up Gcc Romain Francoise
2012-05-21 11:46 ` Sven Joachim
2012-05-21 23:29   ` Katsumi Yamaoka [this message]
2012-05-22  7:38     ` Romain Francoise
2012-06-07 23:00       ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4md35xru4a.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=11514-done@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=romain@orebokech.com \
    --cc=svenjoac@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).