* bug#24034: 25.0.95; shr-fill-line multiplies the number of images
@ 2016-07-20 10:28 Katsumi Yamaoka
2016-07-20 10:31 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Katsumi Yamaoka @ 2016-07-20 10:28 UTC (permalink / raw)
To: 24034
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Hi,
If `gnus-inhibit-images' is t, shr shows the alt text of an image
in the article buffer. If the alt text is long, `shr-fill-line'
devides it into two or more lines, and each line will get to
have a link to the image individually. In that case, those
number of images will be displayed when a user invokes the WDW
command (gnus-article-show-images) even if there should be only
a single image.
The cause of this problem is that `shr-fill-line' divides not
only the alt text but also the `image-url' text property. So,
I'd like to install the following change. This is the right
fix, isn't it?
Regards,
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 661 bytes --]
--- shr.el~ 2016-03-21 22:00:40.983451400 +0000
+++ shr.el 2016-07-20 10:26:30.487350400 +0000
@@ -636,13 +636,12 @@
;; Success; continue.
(when (= (preceding-char) ?\s)
(delete-char -1))
- (let ((face (get-text-property (point) 'face))
+ (let ((props (text-properties-at (point)))
(background-start (point)))
(insert "\n")
(shr-indent)
- (when face
- (put-text-property background-start (point) 'face
- `,(shr-face-background face))))
+ (when props
+ (add-text-properties background-start (point) props)))
(setq start (point))
(shr-vertical-motion shr-internal-width)
(when (looking-at " $")
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#24034: 25.0.95; shr-fill-line multiplies the number of images
2016-07-20 10:28 bug#24034: 25.0.95; shr-fill-line multiplies the number of images Katsumi Yamaoka
@ 2016-07-20 10:31 ` Lars Ingebrigtsen
2016-07-20 22:57 ` Katsumi Yamaoka
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2016-07-20 10:31 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: 24034
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> The cause of this problem is that `shr-fill-line' divides not
> only the alt text but also the `image-url' text property. So,
> I'd like to install the following change. This is the right
> fix, isn't it?
Yes, I think so.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#24034: 25.0.95; shr-fill-line multiplies the number of images
2016-07-20 10:31 ` Lars Ingebrigtsen
@ 2016-07-20 22:57 ` Katsumi Yamaoka
0 siblings, 0 replies; 3+ messages in thread
From: Katsumi Yamaoka @ 2016-07-20 22:57 UTC (permalink / raw)
To: larsi; +Cc: 24034-done
On Wed, 20 Jul 2016 12:31:56 +0200, Lars Ingebrigtsen wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> The cause of this problem is that `shr-fill-line' divides not
>> only the alt text but also the `image-url' text property. So,
>> I'd like to install the following change. This is the right
>> fix, isn't it?
> Yes, I think so.
Done. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-20 22:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-20 10:28 bug#24034: 25.0.95; shr-fill-line multiplies the number of images Katsumi Yamaoka
2016-07-20 10:31 ` Lars Ingebrigtsen
2016-07-20 22:57 ` Katsumi Yamaoka
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).