From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode. Date: Thu, 26 Jan 2017 17:10:51 +0900 Organization: Emacsen advocacy group Message-ID: References: <87tx5gfyx5.fsf@yahoo.fr> <87fuk7lygr.fsf@gnus.org> <87mvee7qkc.fsf@gnus.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1485418342 9308 195.159.176.226 (26 Jan 2017 08:12:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Jan 2017 08:12:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (i686-pc-cygwin) Cc: Nicolas Richard , 18257@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 26 09:12:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWfAG-0001yH-QZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Jan 2017 09:12:17 +0100 Original-Received: from localhost ([::1]:36705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWfAK-0003ry-8g for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Jan 2017 03:12:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWfA7-0003pk-BR for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2017 03:12:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWfA3-0005k0-CA for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2017 03:12:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45931) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWfA3-0005jg-9V for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2017 03:12:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cWfA2-0004g6-2y; Thu, 26 Jan 2017 03:12:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87tx5gfyx5.fsf@yahoo.fr> Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 26 Jan 2017 08:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18257 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: fixed Original-Received: via spool by 18257-submit@debbugs.gnu.org id=B18257.148541826317913 (code B ref 18257); Thu, 26 Jan 2017 08:12:02 +0000 Original-Received: (at 18257) by debbugs.gnu.org; 26 Jan 2017 08:11:03 +0000 Original-Received: from localhost ([127.0.0.1]:44129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWf95-0004er-JG for submit@debbugs.gnu.org; Thu, 26 Jan 2017 03:11:03 -0500 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:55083 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWf94-0004eL-3H for 18257@debbugs.gnu.org; Thu, 26 Jan 2017 03:11:02 -0500 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1cWf8v-004Ft1-L1; Thu, 26 Jan 2017 02:10:54 -0600 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:ItaNfWg8rdmDXahqrSDPSqvCwuM= X-OutGoing-Spam-Status: No, score=-0.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128530 Archived-At: --=-=-= On Wed, 25 Jan 2017 22:55:15 +0100, Lars Ingebrigtsen wrote: > Just binding "C-c" in the article buffer (like other prefixed) led to > problems in other parts of Emacs somehow, so I've reverted that patch > and will have to implement it a different way. Sorry, that is my fault. How about this patch? * lisp/gnus/gnus-art.el (gnus-article-describe-bindings): Ignore summary commands that aren't bound to gnus-article-read-summary-keys. --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- gnus-art.el~ 2017-01-25 22:07:29.825734200 +0000 +++ gnus-art.el 2017-01-26 08:10:00.743177500 +0000 @@ -6846,16 +6846,20 @@ (let ((keymap (copy-keymap gnus-article-mode-map)) (map (copy-keymap gnus-article-send-map)) (sumkeys (where-is-internal 'gnus-article-read-summary-keys)) + (summap (make-sparse-keymap)) parent agent draft) (define-key keymap "S" map) (define-key map [t] nil) + (define-key summap [t] 'undefined) (with-current-buffer gnus-article-current-summary + (dolist (key sumkeys) + (define-key summap key (key-binding key (current-local-map)))) (set-keymap-parent keymap (if (setq parent (keymap-parent gnus-article-mode-map)) (prog1 (setq parent (copy-keymap parent)) - (set-keymap-parent parent (current-local-map))) + (set-keymap-parent parent summap)) (current-local-map))) (set-keymap-parent map (key-binding "S")) (let (key def gnus-pick-mode) --=-=-=--