From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: Re: Bad value in file-coding-system-alist Date: Sat, 07 Jul 2007 10:43:51 +0900 Message-ID: References: <468BCE38.20402@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1183772649 16600 80.91.229.12 (7 Jul 2007 01:44:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 7 Jul 2007 01:44:09 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: "Lennart Borgman \(gmail\)" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 07 03:44:06 2007 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I6zL9-0006jd-Ce for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jul 2007 03:44:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I6zL8-0005SC-Ta for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2007 21:44:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I6zL7-0005S4-1R for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2007 21:44:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I6zL4-0005Rm-5a for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2007 21:43:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I6zL4-0005Rj-07 for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2007 21:43:58 -0400 Original-Received: from washington.hostforweb.net ([66.225.201.13]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I6zL3-0002Gt-Ko for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2007 21:43:57 -0400 Original-Received: from [218.118.2.103] (port=62443 helo=) by washington.hostforweb.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1I6zKx-0000Er-KD; Fri, 06 Jul 2007 20:43:51 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) Cancel-Lock: sha1:kijJWVKy47s8nKCeHdsuEHTfl4A= X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - washington.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-kernel: Genre and OS details not recognized. X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16100 Archived-At: >>>>> "Lennart Borgman (gmail)" wrote: > But is this really the right fix? It looks to me like there is a more > general bug in customize, please see the message I sent after the one > you responded to hear. I see. Thanks. I guess the reason the `coding-system' widget doesn't check whether the value is a coding system is for the coding systems that are defined afterward, e.g., the ones to be autoloaded. So, I think the right fix is to check whether the value is not a function. A new patch is below. WDYT? *** cus-start.el~ Tue Jul 3 14:41:31 2007 --- cus-start.el Sat Jul 7 01:41:21 2007 *************** *** 122,129 **** :value (undecided . undecided) (coding-system :tag "Decoding") (coding-system :tag "Encoding")) ! (coding-system :tag "Single coding system" ! :value undecided) (function :value ignore)))) (selection-coding-system mule coding-system) ;; dired.c --- 122,134 ---- :value (undecided . undecided) (coding-system :tag "Decoding") (coding-system :tag "Encoding")) ! (coding-system ! :tag "Single coding system" ! :value undecided ! :match (lambda (widget value) ! (and value ! (symbolp value) ! (not (functionp value))))) (function :value ignore)))) (selection-coding-system mule coding-system) ;; dired.c P.S. I'm sorry I'm inactive in the net every weekend.