unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 14950-done@debbugs.gnu.org, Jambunathan K <kjambunathan@gmail.com>
Subject: bug#14950: 24.3.50; gnus: Fontification of URLs is not satisfactory
Date: Fri, 26 Jul 2013 08:40:56 +0900	[thread overview]
Message-ID: <b4m38r2yzqv.fsf@jpl.org> (raw)
In-Reply-To: <87y58vgd8y.fsf@gmail.com>

Andreas Schwab wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>> What should be improved is the default value of the user option
>> `gnus-button-url-regexp'.  But it is too complicated to let me
>> encourage to do it without enbugging.  Anyone?

> How about this?

> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
> index 31a108a..2433db2 100644
> --- a/lisp/gnus/gnus-art.el
> +++ b/lisp/gnus/gnus-art.el
> @@ -7177,7 +7177,8 @@ groups."
>  	  "\\(?:"
>  	  ;; Match paired parentheses, e.g. in Wikipedia URLs:
>  	  ;; http://thread.gmane.org/47B4E3B2.3050402@gmail.com
> - "[" chars punct "]+" "(" "[" chars punct "]+" "[" chars "]*)" "["
> chars "]*"
> +	  "[" chars punct "]+" "(" "[" chars punct "]+" "[" chars "]*)"
> +	  "\\(?:" "[" chars punct "]+" "[" chars "]" "\\)?"
>  	  "\\|"
>  	  "[" chars punct     "]+" "[" chars "]"
>  	  "\\)"))

Great!  I understood what what you changed meant.  Thanks.
The original one only matches the last part of a url like:

http://.../abc.def(ghi)jklmno

But yours matches:

http://.../abc.def(ghi)jkl.mno

Maybe making it match the one like

http://.../abc.def(ghi)jkl.mno/pqr(stu)vwx

is not necessary.  I've installed your patch.





      reply	other threads:[~2013-07-25 23:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 10:11 bug#14950: 24.3.50; gnus: Fontification of URLs is not satisfactory Jambunathan K
2013-07-25 11:29 ` Katsumi Yamaoka
2013-07-25 12:15   ` Jambunathan K
2013-07-25 13:11   ` Andreas Schwab
2013-07-25 23:40     ` Katsumi Yamaoka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4m38r2yzqv.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=14950-done@debbugs.gnu.org \
    --cc=kjambunathan@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).