From: Katsumi Yamaoka <yamaoka@jpl.org>
To: 22157@debbugs.gnu.org
Subject: bug#22157: html renderer shr - Links open twice in external browser
Date: Mon, 02 May 2016 18:59:51 +0900 [thread overview]
Message-ID: <b4m1t5kixuw.fsf@jpl.org> (raw)
In-Reply-To: <19694.1449984793@allegro.localdomain>
On Mon, 02 May 2016 16:31:34 +0900, Katsumi Yamaoka wrote:
> I think this is why a link opens twice:
> ・If a link has an image, there are two keymaps `shr-map' and
> `shr-image-map'. `shr-map' binds `mouse-2' to `shr-browse-url',
> and `follow-link' to `mouse-face'; `shr-image-map' has a copy
> of `shr-map' bindings.
No. There are three keymaps. The other one is that of the widget
button, that `mm-convert-shr-links' creates. This might be the
reason why it doesn't happen with MH-E.
> ・The `follow-link' binding responds to the `mouse-1' button if
> `mouse-1-click-follows-link' is non-nil (the default).
But I don't know why it responds to a single `mouse-1' click twice
so far. It might otherwise not be the cause.
> A fix would be:
> --- shr.el~ 2016-04-24 22:03:10.675591200 +0000
> +++ shr.el 2016-05-02 07:23:19.038316700 +0000
> @@ -191,7 +191,7 @@
> map))
> (defvar shr-image-map
> - (let ((map (copy-keymap shr-map)))
> + (let ((map (make-sparse-keymap)))
> (when (boundp 'image-map)
> (set-keymap-parent map image-map))
> map))
This fixes the problem anyway.
I tried making a simple test program that reproduce the `twice'
problem, but haven't succeeded in it yet.
next prev parent reply other threads:[~2016-05-02 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19694.1449984793@allegro.localdomain>
2016-02-01 1:19 ` bug#22157: still present in 25.0.90 Mike Kupfer
[not found] ` <m2vb349303.fsf@krugs.de>
2016-04-28 3:47 ` bug#22157: html renderer shr - Links open twice in external browser Mike Kupfer
2016-04-28 7:43 ` Rainer M Krug
2016-04-28 17:43 ` bug#22157: problem only seen with Gnus, not MH-E Mike Kupfer
2016-05-02 7:31 ` bug#22157: html renderer shr - Links open twice in external browser Katsumi Yamaoka
2016-05-02 9:59 ` Katsumi Yamaoka [this message]
2016-05-06 1:37 ` Katsumi Yamaoka
2016-05-06 8:43 ` Nicolas Petton
2016-06-10 8:35 ` Katsumi Yamaoka
2016-06-10 9:23 ` Stephen Berman
2016-06-10 13:58 ` martin rudalics
2016-06-13 1:22 ` Katsumi Yamaoka
2016-06-22 10:41 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4m1t5kixuw.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=22157@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).