From: Daniel Sausner <daniel.sausner@posteo.de>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 52003@debbugs.gnu.org
Subject: bug#52003: Unexpected advising behavior due to recursive implementation
Date: Sun, 21 Nov 2021 09:32:43 +0000 [thread overview]
Message-ID: <b48e92fa-fe77-c733-d99c-46ffdc4f2408@posteo.de> (raw)
In-Reply-To: <43094E20-7F74-4CE0-ABE7-4348ADFFFCE0@acm.org>
> Do remember that you are always on your own when using advice; Emacs
> cannot reasonably promise any compatibility on that level.
I see. I somehow assumed that functions at that level would aim to be
compliant to the max.
> That said, it would be straightforward to straighten out the control flow by extracting the bulk of the code to a new (internal) function which is called with or without `condition-case`. It would be slightly slower since it entails an extra function call in the non-interactive case, and forward-sexp and its ilk are workhorses in many language modes. It may not matter much, of course.
Well, I'd say that in that case the non-interactive performance
outweighs this particular corner case of advising these core functions,
which I came to understand is a hot iron.
Therefore I'd say this bug report can be closed from my point of view. I
guess I still have to use advising as I currently see no other feasible
way out, but I can make it sensitive to `interactive` as well.
Thanks for the helpful input!
next prev parent reply other threads:[~2021-11-21 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 16:13 bug#52003: Unexpected advising behavior due to recursive implementation Daniel Sausner
2021-11-20 19:16 ` Mattias Engdegård
2021-11-21 9:32 ` Daniel Sausner [this message]
2021-11-21 11:08 ` Mattias Engdegård
2021-11-21 17:29 ` Daniel Sausner
2021-11-22 9:20 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b48e92fa-fe77-c733-d99c-46ffdc4f2408@posteo.de \
--to=daniel.sausner@posteo.de \
--cc=52003@debbugs.gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).