From: Dmitry Gutov <dmitry@gutov.dev>
To: Alan Mackenzie <acm@muc.de>
Cc: 73880@debbugs.gnu.org
Subject: bug#73880: Master: emacs-lisp-mode: Tab completion for a function position fails in a `let' form.
Date: Sun, 27 Oct 2024 03:29:08 +0200 [thread overview]
Message-ID: <b48be956-3fab-4d24-857d-1b1d9fae2c6c@gutov.dev> (raw)
In-Reply-To: <Zx1oqOxkNTf26vWB@MAC.fritz.box>
On 27/10/2024 01:09, Alan Mackenzie wrote:
>> BTW, I had to move the corresponding piece of code to a separate
>> function to debug it. Too bad edebug doesn't know how to jump into the
>> 'guard' clauses.
> I found the bug in pcase.el causing this. The edebug spec element
> &interpose, which is used in pcase-PAT absolutely requires that the
> function it uses (in this case pcase--edebug-match-pat-args) must call
> PF. (See edebug.el around L1810.)
>
> What PF (internal function in edebug) does is join up edebug specs with
> what follows.
>
> pcase--edebug-match-pat-args fails to do this for most cases it deals
> with, including guard. As a result, there is no edebug instrumentation
> generated for the argument of guard.
>
> I'm going to raise a bug report for this (answering my question in my
> last post). In the meantime, here is a rough first draught of a fix.
> With it, I can debug the guard clauses in elisp-completion-at-point,
> though I seem to be triggering other problems (I get a message about a
> `_' argument being used after all).
Nice! It works, thank you.
next prev parent reply other threads:[~2024-10-27 1:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 13:09 bug#73880: Master: emacs-lisp-mode: Tab completion for a function position fails in a `let' form Alan Mackenzie
2024-10-20 10:54 ` Alan Mackenzie
2024-10-26 1:50 ` Dmitry Gutov
2024-10-26 14:35 ` Alan Mackenzie
2024-10-27 1:44 ` Dmitry Gutov
2024-10-28 12:12 ` Alan Mackenzie
2024-10-29 0:15 ` Dmitry Gutov
2024-10-26 22:09 ` Alan Mackenzie
2024-10-27 1:29 ` Dmitry Gutov [this message]
2024-10-28 11:19 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b48be956-3fab-4d24-857d-1b1d9fae2c6c@gutov.dev \
--to=dmitry@gutov.dev \
--cc=73880@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).