From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#67417: 29.1.50; c-ts-mode syntax issues with no brackets Date: Sun, 10 Dec 2023 01:29:03 -0800 Message-ID: References: <83h6lbfwcu.fsf@gnu.org> <2ba91823-bf3c-4d5d-e556-1622135ab2fd@gutov.dev> <8f8aa9c5-95cb-44e5-b41e-4cf58f024624@gmail.com> <33b587b2-1ea1-f756-704f-e75a3193c147@gutov.dev> <720463fd-c6d8-4c31-8240-7017984084a4@gmail.com> <0dd74b5b-e1d2-462b-bbc3-01d0e4d71713@gmail.com> <83plzfye5e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29794"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 67417@debbugs.gnu.org, dmitry@gutov.dev, arteen@linux.ucla.edu To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 10 10:30:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCG8R-0007cr-8l for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Dec 2023 10:30:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCG8E-0001iz-Kl; Sun, 10 Dec 2023 04:29:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCG8C-0001ik-Nh for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 04:29:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCG8C-0007Tp-En for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 04:29:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCG8Q-0004wZ-Ce for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 04:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Dec 2023 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67417 X-GNU-PR-Package: emacs Original-Received: via spool by 67417-submit@debbugs.gnu.org id=B67417.170220056718922 (code B ref 67417); Sun, 10 Dec 2023 09:30:02 +0000 Original-Received: (at 67417) by debbugs.gnu.org; 10 Dec 2023 09:29:27 +0000 Original-Received: from localhost ([127.0.0.1]:49488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCG7q-0004v8-WC for submit@debbugs.gnu.org; Sun, 10 Dec 2023 04:29:27 -0500 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:42083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCG7o-0004us-Nn for 67417@debbugs.gnu.org; Sun, 10 Dec 2023 04:29:25 -0500 Original-Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1d04c097e34so26561935ad.0 for <67417@debbugs.gnu.org>; Sun, 10 Dec 2023 01:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702200545; x=1702805345; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YMP8wFCnhsqRMpc/z5Vf/Bee/ymwfIjD0ecqR7Olzjs=; b=Q9ZY2kjAO9KLFcuVnXUsGYXPX7ma1XnIu4hIebE0f+dXcFZCcyj2AAeT7JONrIdF6d PZD7I7JJZ1IUzN/SNeIZnJRKwIBRb1RBMVQrUZ4b6/oQQ1FMQFxX3nTUYPTyX3YIj0A6 kjg6fY++4vnt+L5wz1dFEBJkbHBcXYwtyJdVZEglqK4kolb4PfM9ShvT77TF9/Y2XN30 uFW2/DPd8UBsDYEGA8e71lzNJ9W4rWaggcLiJR87BPMdSMPJJIDqI9CBlyURry4n288U G6TXVTv89eco2UEsraGK7ZitVnoS3mvMaGujBN+wQ5+T3yfMGeG2nG+uZvNaTj9iwdZA 9pNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702200545; x=1702805345; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YMP8wFCnhsqRMpc/z5Vf/Bee/ymwfIjD0ecqR7Olzjs=; b=JlqqaV2NqRE3KDNUsiMkY+KhbuUlB8nhDZ7pv4Pz+5I5fuewM67dc6p6w1j3/SU1lw KjWrB5AGcWBF7tWeciQvOTPflHLfxsbFH9H15k1DiAKXymTE47u7E/WH1AKOxCnI0NWd fQfol0nlevmMNMGBQfbOvpBP6JvVxZwRsq3M6pAiO2i+u0T82fGzHbeabwGLeFqjK4/I PxtoYnrlk09f6PsEbU3qlDmdBj417h4rF3I+1sSeExHLITjmL8H+iKIXzmOqYTEaXPBy rQ9xwJgHSAqqdAWhzi5X1gpLIvWMk8KNgl+TurLyfXCkJ7h5aBgzgzRnuH2ilFJrTQXh vqng== X-Gm-Message-State: AOJu0Ywt629sRkXZuAiT4Owr/o5cUJO7202OzPslDbES+dT0cgIfpi2c pZWV+W9jimVQ5ryY+kEwNxE= X-Google-Smtp-Source: AGHT+IHqDCt/GTrONVeKLwBPdqhIMv3JMt8XnDfWNRPq1lnKzbNr94dOdr7QTeGN1WLtwkpzaC6h9w== X-Received: by 2002:a17:903:41c1:b0:1d0:6ffd:611c with SMTP id u1-20020a17090341c100b001d06ffd611cmr3095324ple.62.1702200544647; Sun, 10 Dec 2023 01:29:04 -0800 (PST) Original-Received: from [192.168.1.7] (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id l4-20020a170903244400b001d060c61da5sm4500524pls.134.2023.12.10.01.29.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Dec 2023 01:29:04 -0800 (PST) Content-Language: en-US In-Reply-To: <83plzfye5e.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275905 Archived-At: On 12/9/23 12:27 AM, Eli Zaretskii wrote: >> Date: Thu, 30 Nov 2023 23:58:14 -0800 >> Cc: 67417@debbugs.gnu.org >> From: Yuan Fu >> >>> The rest of the nodes (if/while/do/for) don't result in parse errors >>> here, as long as the condition in parentheses is typed out correctly. >>> >>> I tried some additional clauses looking for "previous sibling", >>> checking whether it's for_statement, etc, which ends with "expression >>> statement", and that one is empty... but it a fair amount of code >>> which will likely miss other edge cases anyway. Or breaks when the >>> grammar changes. >> Yeah, for now we can match for the specific case where there's an else >> before a "}". That should reduce the chance of it matching other edge >> cases. I'll give it another look on this weekend. > Any progress here? I pushed a commit that changes the too-board heuristic to only match "else before closing bracket". Hopefully this won't cause any false matches. I think we can close this. Dmitry, WDYT? Yuan