From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Mon, 01 Aug 2022 09:56:11 +0000 Message-ID: References: <837d46mjen.fsf@gnu.org> <8a3eaeef01be5bfaa5ef@heytings.org> <05388e8d8812bfa3695d@heytings.org> <83v8rf5894.fsf@gnu.org> <65cb7c73fd4a999cca00@heytings.org> <8c7321f2f3400a5db9be@heytings.org> <8c7321f2f388e5343475@heytings.org> <6ea376f6-d503-06d8-6d83-50c52b695394@yandex.ru> <8c7321f2f3ac52bfee4b@heytings.org> <8c7321f2f3ec1ef81af9@heytings.org> <02e83b0e-1b5c-fe75-6e59-1f8ddff82d37@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Lzs0iVlIyH" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25107"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 01 11:57:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oISAj-0006Nx-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 11:57:14 +0200 Original-Received: from localhost ([::1]:58206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oISAi-0006r0-D1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 05:57:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oISAY-0006qj-PY for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 05:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oISAY-0007LC-Dq for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 05:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oISAY-0003Hu-7a for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 05:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Aug 2022 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.165934777612537 (code B ref 56682); Mon, 01 Aug 2022 09:57:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 1 Aug 2022 09:56:16 +0000 Original-Received: from localhost ([127.0.0.1]:39362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIS9o-0003G6-29 for submit@debbugs.gnu.org; Mon, 01 Aug 2022 05:56:16 -0400 Original-Received: from heytings.org ([95.142.160.155]:33504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIS9l-0003Fw-3f for 56682@debbugs.gnu.org; Mon, 01 Aug 2022 05:56:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1659347771; bh=F/jVLS/ydCFop02didMlEQeDYiH64KKddIKnArU02P4=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=JZDV9D3ox6l1ArRSnVm4HEL8SExTtHp8VULcvulghoA0ZraJBvh68q3LonQIq/bQ9 iq5n5AdlyZqbgGVfTRmPT2dUXR0GgI+lT7zKDNS5wa26QKYRCHsDpivOwBsHwtKFOS fgaoB+gPOD6MwyKAlRqG2+4onPpeHR6X6Zq0maKPm/I216zMnJeGP5rdlVP6kTA1mR DLfLZjboySMV7r16vWHPVhvGvoY6VPRWtzrRUPiW1icaLdEQhOEOx/NRkP5AtGEYJ8 4/jSZOIX0yb7PIjN8fQ6fmqAtLRiBQHz1tAkx5pdfXPce1hi5jrfh0Qn4RDVYq6057 MMk7U8yvvE7yA== In-Reply-To: <02e83b0e-1b5c-fe75-6e59-1f8ddff82d37@yandex.ru> Content-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238399 Archived-At: --Lzs0iVlIyH Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-ID: >> Given your and Dmitry's feedback, I just tried to add an explicit call= =20 >> to (syntax-ppss (point-max)), without narrowing, when the buffer is=20 >> opened (see below). >>=20 >> The problem is that this is, as I said, slow.=C2=A0 On my laptop, openin= g a=20 >> 1 GB file takes about 6 seconds.=C2=A0 The call to syntax-ppss adds 70= =20 >> seconds, so opening a large file becomes an order of magnitude slower=20 >> (13 times slower).=C2=A0 Which I think is too much for the added benefit= =2E > > But that only has to happen when the buffer is scrolled to the bottom,=20 > right? > No, it happens when the buffer is opened. Given the importance that you=20 and Stefan seem to give to that function, it is, with the patch I sent in= =20 my previous post, called once on the whole buffer (without any narrowing)= =20 when the file is opened. Later calls (inside fontification-functions or=20 post-command-hook) are subject to a forced narrowing. > > And syntax-ppss's speed depends on the rules applied by the particular=20 > major mode. Those could be sped up. Some optimization of this function's= =20 > speed is not out of the question either. > They would be more than welcome. In fact, without such optimizations, it= =20 would be unreasonable to do what the patch does. --Lzs0iVlIyH--