From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Mon, 01 Aug 2022 13:30:44 +0000 Message-ID: References: <83o7xccagi.fsf@gnu.org> <831qu7daxb.fsf@gnu.org> <83sfmnb7yg.fsf@gnu.org> <837d3ybh5z.fsf@gnu.org> <136c4fe0fc74196714aa@heytings.org> <83pmhp89ov.fsf@gnu.org> <136c4fe0fc39573addc9@heytings.org> <83k07x8738.fsf@gnu.org> <136c4fe0fcdf00ef9a11@heytings.org> <83h73183r7.fsf@gnu.org> <136c4fe0fc0fceb0d752@heytings.org> <838roc8ka7.fsf@gnu.org> <83tu706obt.fsf@gnu.org> <83h7306ifa.fsf@gnu.org> <83edy37pul.fsf@gnu.org> <83pmhn55sk.fsf@gnu.org> <65cb7c73fdc753518d35@heytings.org> <83fsii68o3.fsf@gnu.org> <65cb7c73fdf6704d19d5@heytings.org> <835yje62vz.fsf@gnu.org> <83r1214uz5.fsf@gnu.org> <8c7321f2f39b7a28dd18@heytings.org> <83o7x42l64.fsf@gnu.org> <83h72w2jk7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32441"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 01 15:42:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIVh9-0008Ca-G1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 15:42:55 +0200 Original-Received: from localhost ([::1]:35572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIVh8-0006Im-IE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 09:42:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIVVe-0001YD-LQ for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 09:31:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIVVe-0002J8-9w for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 09:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIVVe-0005hr-1c for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 09:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Aug 2022 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.165936064921587 (code B ref 56682); Mon, 01 Aug 2022 13:31:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 1 Aug 2022 13:30:49 +0000 Original-Received: from localhost ([127.0.0.1]:39756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIVVQ-0005bU-OU for submit@debbugs.gnu.org; Mon, 01 Aug 2022 09:30:49 -0400 Original-Received: from heytings.org ([95.142.160.155]:33846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIVVO-0005Y9-Ez for 56682@debbugs.gnu.org; Mon, 01 Aug 2022 09:30:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1659360645; bh=Dm+eafzNyq5qHtsSpTHHjDCMGGk4b18X8iYOOUyg1mc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Gv5ZUiySKNLuxGNwYh1359QzDId5HiSnT7I+hzyznqQE6xOOquapkCc3qj4wx8vf9 s6rdOrNn27s9YTLYOwb9+tDol/7CA7NMsDsoIlUXK/4QbdRn6PLpVB1btDDcL02J/P eWSGKeXuppI85IPzAyc1tlgrcchHIe66Z36N4nJpnQb5wmch4wazmKR1ukEX9STrbM YzxPegmznw1+JCCk30a77IV/sSiHfACKydW8VFZzKqBGXoP5ww1NnjhD11sVr8GvUz 0CVH+ADns1jbKhCPOmWRIFrtOJjgTx3ueTYA83qiDK4KO0Du4kiWSUxB6qnCi5FC0h KZZBHc7vKytwA== In-Reply-To: <83h72w2jk7.fsf@gnu.org> Content-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238438 Archived-At: >>> Which means, for example, that tests like this: >>> >>> if (current_buffer->long_line_optimizations_p) >>> { >>> if (!it->narrowed_begv <<<<<<<<<<<<<<<<<<<<<<<<<< >>> || ((pos.charpos < it->narrowed_begv || pos.charpos > it->narrowed_zv) >>> && (!redisplaying_p || it->line_wrap == TRUNCATE))) >>> >>> are not necessarily reliable, because we never initialize >>> narrowed_begv to zero, AFAICT. Right? >> >> Indeed. That wasn't a problem with the previous code in which >> narrowed_begv was unconditionally assigned. Now it is. I think the >> following change should be enough to fix this. Agreed? > > Yes, of course. > Thanks; now pushed.