unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: David Ponce <da_vid@orange.fr>
To: 41251@debbugs.gnu.org
Subject: bug#41251: 28.0.50; Cannot customize mouse-drag-and-drop-region modifier
Date: Thu, 14 May 2020 10:48:13 +0200	[thread overview]
Message-ID: <b357e592-790f-4141-b807-da28e0013cd1@orange.fr> (raw)

Hello,

There is an issue in the definition of `mouse-drag-and-drop-region' that
will not correctly set the option depending on selected modifier. That
is, when any option "Enable, but copy with the MODIFIER modifier" is
set, the value of `mouse-drag-and-drop-region' is always set to the
symbol 'modifier instead of 'alt, 'super, 'hyper, 'shift, 'control, or
'meta, depending on the selected option. It seems due to a missing comma
in the backquote expression.

The below patch fixed the issue for me:

diff --git a/installs/emacs/lisp/mouse.el b/emacs.d/mouse.el
index 9703d95..795b4da 100644
--- a/installs/emacs/lisp/mouse.el
+++ b/emacs.d/mouse.el
@@ -2556,7 +2556,7 @@ region, text is copied instead of being cut."
               (lambda (modifier)
                 `(const :tag ,(format "Enable, but copy with the %s modifier"
                                       modifier)
-                       modifier))
+                       ,modifier))
               '(alt super hyper shift control meta))
            (other :tag "Enable dragging the region" t))
    :version "26.1")

Thanks!

In GNU Emacs 28.0.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, cairo version 1.16.0)
  of 2020-05-12 built on kilauea
Repository revision: 4645430b9287c3f5ae9863d465a5dd4158e313a9
Repository branch: master
Windowing system distributor 'Fedora Project', version 11.0.12006000
System Description: Fedora 31 (KDE Plasma)






             reply	other threads:[~2020-05-14  8:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14  8:48 David Ponce [this message]
2020-05-14 10:27 ` bug#41251: 28.0.50; Cannot customize mouse-drag-and-drop-region modifier Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b357e592-790f-4141-b807-da28e0013cd1@orange.fr \
    --to=da_vid@orange.fr \
    --cc=41251@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).