From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#19062: 25.0.50; `Info-bookmark-jump' changes frames - see FIXME in code Date: Sat, 22 Aug 2020 21:40:52 -0700 (PDT) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19808"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 19062@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 23 06:42:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9hpZ-00052u-PK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Aug 2020 06:42:09 +0200 Original-Received: from localhost ([::1]:35946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9hpY-0005gF-GJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Aug 2020 00:42:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9hpS-0005g7-Lu for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 00:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9hpS-00053D-Cw for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 00:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k9hpS-0006o5-8e for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 00:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Aug 2020 04:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19062 X-GNU-PR-Package: emacs Original-Received: via spool by 19062-submit@debbugs.gnu.org id=B19062.159815766526101 (code B ref 19062); Sun, 23 Aug 2020 04:42:02 +0000 Original-Received: (at 19062) by debbugs.gnu.org; 23 Aug 2020 04:41:05 +0000 Original-Received: from localhost ([127.0.0.1]:51905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9hoX-0006mv-AX for submit@debbugs.gnu.org; Sun, 23 Aug 2020 00:41:05 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:43742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9hoT-0006mH-6f for 19062@debbugs.gnu.org; Sun, 23 Aug 2020 00:41:04 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07N4eTb6145974; Sun, 23 Aug 2020 04:40:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=TM7JeGVjOmdap5mZsZFpIq6KP/SdE6Ud1oL5meGr1oc=; b=itIhxvRrt+0YZqNF0nUlq8Jhd7hjgieFC42MLL8RrqUKn3osNt13kx6BJgRpT+usJT/H U6gqlGI5gyEY/g3Ul3zHb0r5Q/Mly01O78FC9zkoTgXlzqZVamb4zk40U46aQnMsCVvK Jkk8v36kAHQUbaA1esjFI/rgH7eL6T3mNJyVLkv8xB9LedPikeEMAw8AXOxsyFl/Cimg FFORbyw/4WLRC5hRy3IxQywAgClztn8PBe1kN0puMYee5Fh/vvewOux7DlmVfW/0aA6H SA8L6Ewsk71CH+zT41wq1o+Jd9e/oXDHCDW6F3xfVuZ/vDdvKUvjOtLM7HYJGNDPeqSG Lg== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 333cse09xn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 23 Aug 2020 04:40:55 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07N4d8nE168183; Sun, 23 Aug 2020 04:40:54 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 333d9u4gnt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 23 Aug 2020 04:40:54 +0000 Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07N4eqMC029285; Sun, 23 Aug 2020 04:40:53 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9721 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008230051 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9721 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 impostorscore=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1011 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008230052 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186018 Archived-At: > > See the FIXME in the source code. My setup is too involved to present > > here. Suffice it to say that the `Info-bookark-jump' code messes with > > the frame that was selected before popping up the Info frame (for > > `Info-find-node'). (I get a separate frame for the Info buffer because > > `special-display-regexps' is `("[ ]?[*][^*]+[*]")'.) >=20 > I don't understand the problem here. I set the following, according to > your suggestion: >=20 > (setq special-display-regexps '("[ ]?[*][^*]+[*]")) >=20 > And I've experimented a bit with jumping to info bookmarks without > seeing anything unusual. Sorry, but a year later I don't recall the details. The "FIXME" is maybe self-explanatory: `save-window-excursion' can't restore the window config of the frame that was selected before, if a different frame is selected afterward. It does this: (let ((,c (current-window-configuration))) (unwind-protect (progn ,@body) (set-window-configuration ,c))) If BODY selects a different frame then the `set-window-configuration' is evaluated there, which can't be right. I don't know now whether the report was just to point out the FIXME or whether it affected me. I do get a separate frame for Info buffers, but I don't know what to do to check whether the window config in the original buffer doesn't get restored correctly (I don't see how it could) or whether trying to restore it in the newly selected frame is problematic (I don't notice that it is, but I don't fiddle with window configs, so I don't think I'd notice, if it did). I think a proper test would need to involve doing something additional to the handler, to first modify the original window config, then let the new frame get selected, and see that the original window config didn't get restored (it couldn't, AFAICT). I think the point of the bug report was probably just to point to the FIXME. Sorry I've forgotten.