unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Kangas <stefan@marxist.se>, 19062@debbugs.gnu.org
Subject: bug#19062: 25.0.50; `Info-bookmark-jump' changes frames - see FIXME in code
Date: Sat, 22 Aug 2020 21:40:52 -0700 (PDT)	[thread overview]
Message-ID: <b340e5b1-2aa9-41bc-b34c-0011d190b0f3@default> (raw)
In-Reply-To: <CADwFkmn9yV5+OsdL80_5eUv92B1eoTOBt3HzzPoebtLZF1woDg@mail.gmail.com>

> > See the FIXME in the source code.  My setup is too involved to present
> > here.  Suffice it to say that the `Info-bookark-jump' code messes with
> > the frame that was selected before popping up the Info frame (for
> > `Info-find-node').  (I get a separate frame for the Info buffer because
> > `special-display-regexps' is `("[ ]?[*][^*]+[*]")'.)
> 
> I don't understand the problem here.  I set the following, according to
> your suggestion:
> 
> (setq special-display-regexps '("[ ]?[*][^*]+[*]"))
> 
> And I've experimented a bit with jumping to info bookmarks without
> seeing anything unusual.

Sorry, but a year later I don't recall the details.

The "FIXME" is maybe self-explanatory:
`save-window-excursion' can't restore the window config
of the frame that was selected before, if a different
frame is selected afterward.  It does this:

(let ((,c (current-window-configuration)))
   (unwind-protect (progn ,@body)
     (set-window-configuration ,c)))

If BODY selects a different frame then the
`set-window-configuration' is evaluated there,
which can't be right.

I don't know now whether the report was just
to point out the FIXME or whether it affected me.

I do get a separate frame for Info buffers, but
I don't know what to do to check whether the
window config in the original buffer doesn't
get restored correctly (I don't see how it could)
or whether trying to restore it in the newly
selected frame is problematic (I don't notice that
it is, but I don't fiddle with window configs, so
I don't think I'd notice, if it did).

I think a proper test would need to involve doing
something additional to the handler, to first
modify the original window config, then let the
new frame get selected, and see that the original
window config didn't get restored (it couldn't,
AFAICT).

I think the point of the bug report was probably
just to point to the FIXME.  Sorry I've forgotten.





  parent reply	other threads:[~2020-08-23  4:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 15:51 bug#19062: 25.0.50; `Info-bookmark-jump' changes frames - see FIXME in code Drew Adams
2019-07-02  3:52 ` Stefan Kangas
2020-08-23  1:45   ` Stefan Kangas
2020-08-23  4:40   ` Drew Adams [this message]
2020-09-02 15:19     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b340e5b1-2aa9-41bc-b34c-0011d190b0f3@default \
    --to=drew.adams@oracle.com \
    --cc=19062@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).