From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#16074: 24.3.50; enhancement request: Remove "pop" from command names & doc for `C-(u|x) C-SPC' Date: Sun, 25 Aug 2019 09:14:55 -0700 (PDT) Message-ID: References: <87y2zh94nz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="77250"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 16074@debbugs.gnu.org To: Lars Ingebrigtsen , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 18:16:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1vBc-000Jzj-8k for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 18:16:12 +0200 Original-Received: from localhost ([::1]:43582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1vBa-0006sL-4o for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 12:16:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32879) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1vBU-0006sD-1B for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 12:16:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1vBS-00068j-Oc for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 12:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1vBS-00068W-Ka for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 12:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1vBS-00031j-Aj for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 12:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16074 X-GNU-PR-Package: emacs Original-Received: via spool by 16074-submit@debbugs.gnu.org id=B16074.156674970811560 (code B ref 16074); Sun, 25 Aug 2019 16:16:02 +0000 Original-Received: (at 16074) by debbugs.gnu.org; 25 Aug 2019 16:15:08 +0000 Original-Received: from localhost ([127.0.0.1]:45001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vAZ-00030O-KI for submit@debbugs.gnu.org; Sun, 25 Aug 2019 12:15:07 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:49298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vAX-0002zZ-98 for 16074@debbugs.gnu.org; Sun, 25 Aug 2019 12:15:06 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7PGExFS140432; Sun, 25 Aug 2019 16:14:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=Ck9lL0xbxig9g1BTPoZXMxNL99tr0DH7NVcdtnr+TSI=; b=ClcJk2Hf/nGZr3w6gMfG+eRz+wb+g9bqbuhlC8G/DaM7RiPteA7eLILFb0Xu4okgW4l9 MPpf2rhUFeNjXBJ/dUfSG8ia2Mg9C5ffWKdHfxYL1EiwzKugmfHp3uNhFnzjtxSeoaQz wXNvZtaMzIv9LET5p7fMKNiTPNybhIGc/SVg/6FB+Xu40A0KlRDMjYzhrSKoKi27Rsrq tUdQLpW4gQ1jqVcLmWCqkSAZ8FJACnmKk8OHJA1uSeYc6MJ3v5mLs4PncRbCmZs526Ht jCbUQ9wmhGQemDKuzHgoMRR93xkISUuhCIxPstjFmCxPB4F0szXhAzkflaqZKIwO9WRX Hw== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2ujw714j9x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Aug 2019 16:14:58 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7PGED1k035546; Sun, 25 Aug 2019 16:14:58 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2ujw6gw8st-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Aug 2019 16:14:58 +0000 Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7PGEuX1002564; Sun, 25 Aug 2019 16:14:56 GMT In-Reply-To: <87y2zh94nz.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9360 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908250181 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9360 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908250181 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165839 Archived-At: > >> Yes, renaming here seems like a good idea. > > > > How about the attached patch? >=20 > I think that looks like the correct solution. It doesn't address the problem for the `mark-ring', does it? My impression was that it addresses it only for `global-mark-ring'. The local `mark-ring' is used much more often than the `global-mark-ring', and its doc is probably accessed much more often. For example - This part of `C-h k C-SPC' is wrong: With prefix argument (e.g., C-u C-SPC), jump to the mark, and set the mark from position popped off the local mark ^^^^^^^^^^ ring (this does not affect the global mark ring). ... If 'set-mark-command-repeat-pop' is non-nil, repeating the C-SPC command with no prefix argument pops the next position off the local (or global) mark ring and jumps there. With C-u C-u as prefix argument, unconditionally set mark where point is, even if 'set-mark-command-repeat-pop' is non-nil. And the doc & name of option `set-mark-command-repeat-pop' are wrong (plus, the line lengths are screwy): Non-nil means repeating C-SPC after popping mark pops it again. That means that C-u C-SPC C-SPC will pop the mark twice, and C-u C-SPC C-SPC C-SPC will pop the mark three times. And the doc & name of function `pop-to-mark-command' are wrong: Jump to mark, and pop a new position for mark off the ring. A position is NOT popped off the ring. That's what's wrong with all of these. Likewise, the doc in the manuals. The enhancement request is to fix this wrong terminology wrt BOTH `global-mark-ring' and `mark-ring'.