unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, Stefan Kangas <stefan@marxist.se>
Cc: 16074@debbugs.gnu.org
Subject: bug#16074: 24.3.50; enhancement request: Remove "pop" from command names & doc for `C-(u|x) C-SPC'
Date: Sun, 25 Aug 2019 09:14:55 -0700 (PDT)	[thread overview]
Message-ID: <b2e6dd7c-d877-4e48-80eb-3c219eb1d4d7@default> (raw)
In-Reply-To: <87y2zh94nz.fsf@gnus.org>

> >> Yes, renaming here seems like a good idea.
> >
> > How about the attached patch?
> 
> I think that looks like the correct solution.

It doesn't address the problem for the `mark-ring',
does it?  My impression was that it addresses it
only for `global-mark-ring'.  The local `mark-ring'
is used much more often than the `global-mark-ring',
and its doc is probably accessed much more often.

For example -

This part of `C-h k C-SPC' is wrong:

 With prefix argument (e.g., C-u C-SPC), jump to the mark,
 and set the mark from position popped off the local mark
                                ^^^^^^^^^^
 ring (this does not affect the global mark ring).
 ...

 If 'set-mark-command-repeat-pop' is non-nil, repeating
 the C-SPC command with no prefix argument pops the next
 position off the local (or global) mark ring and jumps there.

 With C-u C-u as prefix argument, unconditionally set
 mark where point is, even if 'set-mark-command-repeat-pop'
 is non-nil.

And the doc & name of option `set-mark-command-repeat-pop'
are wrong (plus, the line lengths are screwy):

 Non-nil means repeating C-SPC after popping mark
 pops it again.
 That means that C-u C-SPC C-SPC
 will pop the mark twice, and
 C-u C-SPC C-SPC C-SPC
 will pop the mark three times.

And the doc & name of function `pop-to-mark-command'
are wrong:

 Jump to mark, and pop a new position for mark off the ring.

A position is NOT popped off the ring.  That's what's
wrong with all of these.  Likewise, the doc in the
manuals.

The enhancement request is to fix this wrong
terminology wrt BOTH `global-mark-ring' and
`mark-ring'.





  reply	other threads:[~2019-08-25 16:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 15:46 bug#16074: 24.3.50; enhancement request: Remove "pop" from command names & doc for `C-(u|x) C-SPC' Drew Adams
2016-04-29 14:47 ` Lars Ingebrigtsen
2019-08-24  5:40 ` Stefan Kangas
2019-08-24  6:28   ` Eli Zaretskii
2019-08-24 14:20   ` Drew Adams
2019-08-25  5:48   ` Lars Ingebrigtsen
2019-08-25 16:14     ` Drew Adams [this message]
2019-08-25 20:09       ` Juri Linkov
2019-08-25 22:03         ` Drew Adams
2019-08-26  6:26         ` Eli Zaretskii
2020-08-13 10:47           ` Lars Ingebrigtsen
     [not found] <<cb3c1188-7123-413c-b945-6f73ba4557c7@default>
     [not found] ` <<CADwFkmm5ZZZjR6Ua0POYcHTcwubTSnEwzSTZoGUHN42fgWf8aw@mail.gmail.com>
     [not found]   ` <<831rxbjcv1.fsf@gnu.org>
2019-08-24 14:22     ` Drew Adams
     [not found]   ` <<87y2zh94nz.fsf@gnus.org>
     [not found]     ` <<b2e6dd7c-d877-4e48-80eb-3c219eb1d4d7@default>
     [not found]       ` <<87a7bxm12m.fsf@mail.linkov.net>
     [not found]         ` <<837e70h284.fsf@gnu.org>
2019-08-26 13:13           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2e6dd7c-d877-4e48-80eb-3c219eb1d4d7@default \
    --to=drew.adams@oracle.com \
    --cc=16074@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).